809764 - [system] show overlay when device plugged in via usb

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Dietrich Ayala (:dietrich)]

"As a user, I want a dialogue box asking me whether I want to charge my phone,  internet tether or turn on mass storage mode when my phone is plugged into my computer via USB."

UCID: SysOverlay-009

Comment 1

[Dietrich Ayala (:dietrich)]

This is a feature that came out of analysis of the user-stories.

This needs evaluation by Daniel and Clee about whether it's absolutely required for V1.

Comment 2

[Daniel Coloma:dcoloma]

I think it is not absolutely required but it is a super duper very ultra nice to have. Clee, up to you!

Comment 3

[Josh Carpenter [:jcarpenter]]

cc'd Casey, who worked on this issue extensively.

On a related note, WRT to showing a status bar indicator, we do have a USB status bar icon already designed:

https://www.dropbox.com/sh/j8o1trg68rzdtba/8MGcJmTgJm

See: icons-new_roaming.png

We were going to use it as a permissions indicator for WebUSB API but that feature was nixed for v1.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

If bug 798254 is implemented, user will not be able to switch on two incompatible USB features in the Settings app; we would not need the dialog in this bug.

I highly suspect this bug require platform support (beyond System app), so I would recommend we drop this feature and turn to bug 798254 instead.

Comment 5

[Chris Lee [:clee]]

I believe there is a default state today which seems to work just fine.

1) charges the device
2) turns on USB mass storage as long as the toggle is checked in Settings
3) user will need to go setup WiFi hotspot if they want to turn that function on

I would mark this as not blocking for v1.

Comment 6

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

Comment 7

[Josh Carpenter [:jcarpenter]]

Agree w/ Clee that this is non-blocking. Re-setting to ? for triagers to catch.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia TRiage : Duplicate.  -

Comment 10

[Dietrich Ayala (:dietrich)]

This is not a duplicate of bug 798254. That bug is the Settings choices between things like USB and tethering. This bug is specific to USB overlays shown when plugging in USB, regardless of tether. It's a specific UI feature that is separate from the general Settings contention issues.

Re-opening: Is marked out-of-scope for V1, but that doesn't mean we don't want this for a subsequent release.

Comment 11

[Josh Carpenter [:jcarpenter]]

Is USB mass storage turned on by default?

Comment 12

[Jeni]

This issue repros on Build 2012121707020

Repro Steps: 

1. Unlock the phone and open any application or access the phone setting.
2.  Connect the USB cable to a computer.
3.  Look and feel what happens

Expected:
The system overlay notification appears when the user connects the phone with a USB cable. The notification automatically disappears after 1 second and the phone nudges at the same time.

Actual: The battery has a electric bolt picture in it displaying it is charging in top right hand side of screen.  Does not show in system overlay nor does it disappear after 1 second.  Phone also does not nudge once plugged in.  

Note: Same happens whether USB is turned off or on.

Comment 13

[Jeni]

Please ignore previous comment.  

This issue repros in Build 2012121707020

Repro Steps:
1.Plug device into USB
2. View what happens
 Expected:
Choice to charge phone,  internet tether or turn on mass storage mode when plugged into my computer via USB.
Actual:
Nothing is displayed

Comment 14

[Daniel Coloma:dcoloma]

(In reply to Jeni from comment #13)
> Please ignore previous comment.  
> 
> This issue repros in Build 2012121707020
> 
> Repro Steps:
> 1.Plug device into USB
> 2. View what happens
>  Expected:
> Choice to charge phone,  internet tether or turn on mass storage mode when
> plugged into my computer via USB.
> Actual:
> Nothing is displayed

Please note that this User Story has been de-scoped for V1 and hence it is not expected to work or to be tested.

Comment 15

[Jeni]

This issue repros in Build 20130104070203

Repro Steps:
1.Plug device into USB
2. View what happens
 
Expected:
Choice to charge phone,  internet tether or turn on mass storage mode when plugged into my computer via USB.

Actual:
Nothing is displayed

Comment 16

[Josh Carpenter [:jcarpenter]]

Is the default: USB mass storage = On?

Comment 17

[Jeni]

(In reply to Josh Carpenter [:jcarpenter] from comment #16)
> Is the default: USB mass storage = On?

I have tried it both ways, with USB Mass Storage On and Off.

Comment 18

[amiller]

UCID: sysoverlay-011
https://moztrap.mozilla.org/results/case/62586/

Comment 19

[Jeni]

Issue repros

Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Comment 20

[Cody Roesch [:croesch]]

Inari Build: 20130417070205
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia   2d048a9bdae54e4ec7d48326c2130591c8b869b6
Kernel:  Feb 21st

When attaching the USB cable to the Inari device, with or without USB Mass Storage on, there is no dialogue box asking me whether I want to charge my phone, internet tether or turn on mass storage mode.

Comment 21

[Jeni]

Issue repros on 

Leo Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

When plugging in device there is no message given for user to choose to charge their phone,  internet tether or turn on mass storage.

Comment 22

[Jeni]

Issue repros on 
Leo Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1
RIL Version: 01.01.00.019.138 

when plugging in device there is no message giving user options to choose how they want their device to respond

Comment 23

[Chris Kreinbring [:CKreinbring]]

Still repros on Leo 1.1 commercial RIL.

Build ID: 20130715070218
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8
Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Comment 24

[BMO Automation]

Firefox OS is not being worked on