809790 - 'Share' submenu of application menu not scrollable and unable to share from same menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android Aurora 20121107 and Nightly 20121107, Android 4.1.2 (stock), Google Nexus S

Opening the main menu, tapping 'Share' opens the submenu with sharing providers, but this can't be scrolled, neither in portrait nor in landscape mode.

Scrolling the Share menu opened from the address bar context menu works as expected.

Comment 1

[Aaron Train [:aaronmt]]

Using the same build, this works perfectly fine for me; see vid: http://www.youtube.com/watch?v=PUy8BiPC7cU

Comment 2

[Aaron Train [:aaronmt]]

Now on the Nexus S (as opposed to the Galaxy Nexus), I can reproduce.

Comment 3

[Aaron Train [:aaronmt]]

Actually this really depends on how many items you have in the share menu. 

Arch, can you paste a screenshot of the menu open?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: share menu in landscape mode (looks the same from url bar)

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: share providers not visible in landscape mode

Comment 6

[Aaron Train [:aaronmt]]

Yeah I can reproduce, not only does can you not scroll but you can't share (my taps are going nowhere).

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - Any idea when you can get to this?

Comment 8

[Cristian Nicolae (:xti)]

I guess that this issue is specific to Nexus S, because I cannot reproduce it on the latest Nightly build. The Share list scrolls as expected, both in portrait and landscape modes.

Everything works as expected for me on Aurora either.

--
Firefox 19.0a1 (2012-11-19)
Device: Galaxy S2
OS: Android 4.0.3

Comment 9

[Sriram Ramasubramanian [:sriram]]

This is working on S2. Please report if there is a problem in Nexus S still.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, issue still exists with Nightly 20121203.

Comment 11

[Théo Chevalier]

Attachment: Case 1 (not working)

I have the same issue on Galaxy S2 from trunk (20) to Beta (17).

Case 1: When the menu is displayed by the physic menu button on the S2, I see a scroll bar at the right, but can't move the list or click on any item.

Case 2: But, when the menu is displayed by the Firefox menu button, it works.

I run CyanogenMod 10, if it helps.

Comment 12

[Théo Chevalier]

Attachment: Case 2 (working)

Submenu displayed by the Firefox's menu button

Comment 14

[Aaron Train [:aaronmt]]

Where we at with this Sriram?

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

Sriram, still reproducible on the Nexus S, do you have one of those to debug with?

Comment 16

[Sriram Ramasubramanian [:sriram]]

I don't have a Nexus S with ICS to test this. I tried on a Note with ICS, and didn't have any such issues.

If the time taken to resolve the intent, get the list of applications, inflate it and show on a mobile like Nexus S is expensive, I would recommend using the Gingerbread like "ActivityChooser" if there is a "h/w menu button". That would solve this problem. Is that fine?

Comment 17

[Sriram Ramasubramanian [:sriram]]

At https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/GeckoApp.java#l624 :
An addition check of "!hasPermanentMenukey()" would bring up the old activity-chooser.

Comment 18

[Kevin Brosnan [Ex-Mozilla]]

Sriram if you need a Nexus S there is one in the QA Box o' devices on the left of my desk in the QA area.

Comment 19

[Kevin Brosnan [Ex-Mozilla]]

Looks like we know what is going on here no need for a regression range.

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - We need to figure out short-term and long-term approaches to fixing this bug.

Comment 21

[Théo Chevalier]

I found a working case:

Keep holding the Share button something like 1 or 2 seconds, then release it. You can now scroll the submenu.

(Something probably needs to be fully loaded)

Comment 22

[Sriram Ramasubramanian [:sriram]]

Do we use the idea in comment 17?

Comment 23

[Mark Finkle (:mfinkle) (use needinfo?)]

Given that we have this problem and bug 801043, maybe we should just rollback ALL code to use the Android chooser, like we used to, and then work on this and this bug and bug 801043 using bug 825799 as a way forward.

I don't like having this kinda work sometimes, but never the way we want (bug 801043). I'd rather get Fx19 and Fx20 working as well as possible using the old android chooser and work on implementing our ideal design in Fx21.

Thoughts Ian?

Comment 24

[Ian Barlow (:ibarlow)]

Yeah, agreed. If this and bug 801043 aren't easy fixes, let's roll back until this is working right everywhere.

Comment 25

[stefan]

I'm using Firefox 18 on a Nexus 7 (CM10.1 Android 4.2.1), no problem here.
On my Galaxy Note 1 running FF18 (CM10.1 Android 4.2.1) the issue is here.
I'd like to see a rollback to stock Android sharing menu, as far as I'm concerned for ever.

Comment 26

[Aaron Train [:aaronmt]]

This is too late for mozilla-18; suggested wont-fix on status flag.

Comment 27

[stefan]

'Too late' for a fix of an important feature?

Comment 28

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The uses a Share Activity chooser -- like good old days.
Did I just a kill a feature I did? :O :O :O

Comment 29

[George Billios]

same issue with ff18 on Sony Xperia S with CM10. long pressing share menu resolves this but not a very elegant solution and I hope not the long term one!

Comment 30

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8823187cdb

Comment 31

[Sean McArthur [:seanmonstar]]

I get the same thing on my Galaxy S running Jelly Bean using Nightly.

Comment 32

[Sriram Ramasubramanian [:sriram]]

I pushed it today. So tomorrow you could be able to share without any hassle. :)

Comment 33

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0a8823187cdb

Comment 34

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 698093 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Custom share submenu
User impact if declined: So many complaints in Play Store and twitter about going custom, and lack of scrolling.
Testing completed (on m-c, etc.): Landed yesterday on m-c 
Risk to taking this patch (and alternatives if risky): Very very low. This removes a lot of code and reverts back to default version (which is what we support for Gingerbread phones).
String or UUID changes made by this patch: None.

Comment 35

[Sean McArthur [:seanmonstar]]

Yup, downloaded Nightly this morning, and sharing works again. woot :)

Comment 36

[bhavana bajaj [:bajaj]]

Comment on attachment 698093 [details] [diff] [review]
Patch

Approving on aurora considering the user impact and risk profile here.

Comment 37

[bhavana bajaj [:bajaj]]

Taking the user feedback into account, we will consider this bug as a ride-along if we end up having a 18.0.1 depnding on some QA feedback

Request to QA to get as much testing around this issue.

Comment 38

[Aaron Train [:aaronmt]]

Verified fixed (restored old functionality) on trunk mozilla-21 (mozilla-central) via Samsung Galaxy Nexus (Android 4.2.1), Samsung Galaxy SII (Android 4.0), and Motorola Droid Bionic (Android 2.3.4).

Comment 39

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a58d7d553e5e

Comment 40

[Aaron Train [:aaronmt]]

Remember to flip to fixed please :-)

Comment 41

[bhavana bajaj [:bajaj]]

Comment on attachment 698093 [details] [diff] [review]
Patch

Approving the low risk fix for beta , based on Fx18 feedback on this issue

Comment 42

[Alex Keybl [:akeybl]]

We don't have any mobile FF18.0.1 drivers, so marking this bug as wontfix given its lack of criticality.

Comment 43

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5000bd7ffea

Comment 44

[vulcain]

Work on Firefox 19 beta who came yesterday.