809884 - 'Spelt' is not in the US English dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Benoit Girard (:BenWa)]

From what I gather 'Spelt' out should be 'Spelled' outin US english, but there's also Spelt the grain:
http://en.wikipedia.org/wiki/Spelt

Comment 1

[(no longer active)]

See <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary> for how to fix this bug.

Comment 2

[Srinath N [:srinath]]

Hi Ehsan,

I'm interested in working on this. Can you please assign this to me?

Comment 3

[(no longer active)]

Of course.

Comment 4

[Srinath N [:srinath]]

Attachment: Fixing bug 809884

Comment 5

[(no longer active)]

This looks correct, but there should also be changes to en-US.dic.  Did you perhaps forget to include that file in the diff?

Comment 6

[Srinath N [:srinath]]

Attachment: Updating the patch for defect 809884

Hi Ehsan,

Please check this patch. I've marked the previous patch as obsolete. This patch has the changes to en-US.dic

Comment 7

[(no longer active)]

Hmm,  this patch now loses the changes to upstream-hunspell.diff.  :-)  How do you produce your patches?  You should simply be able to run hg diff on the entire tree to get a full patch file...

Comment 8

[Srinath N [:srinath]]

Hi ehsan, 

I added the words following the instructions at https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary
Following that I created a new patch (hg qnew patchname.patch), refreshed the contents (hg qrefresh) and attached the patch over here.

I'll redo this and post a new patch.

Thanks for your patience!

Comment 9

[Srinath N [:srinath]]

Attachment: Fixing bug 809884 (has the dic and hunspell diff files patched)

Updated patch - contains both the upstream-hunspell.diff and en-US.dic

Comment 10

[(no longer active)]

Comment on attachment 683443 [details] [diff] [review]
Fixing bug 809884 (has the dic and hunspell diff files patched)

Review of attachment 683443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 11

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95e3443b626f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95e3443b626f