810025 - Don't output loglines to stdout if they just consist of TEST-START and TEST-END

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

We emit all the lines that a test has logged (using the log() method) after a test has run.  If the test hasn't used log(), this just results in something like:

START LOG:
INFO TEST-START: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:21 GMT+0000 (GMT)
INFO TEST-END: /home/jgriffin/mozilla-central/src/testing/marionette/client/marionette/tests/unit/test_simpletest_sanity.py:test_ok Thu Nov 08 2012 21:15:22 GMT+0000 (GMT)
END LOG:

This is noisy and not very helpful.  Let's output these things only if the test has actually logged something.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Remove noisy log messages,

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 679813 [details] [diff] [review]
Remove noisy log messages,

Review of attachment 679813 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit to add a break statement

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Remove noisy log messages,

Updated with review comments

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 679826 [details] [diff] [review]
Remove noisy log messages,

Carry r+ forward.

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbdd3dac268e

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

How would someone verify that a specific test has been ran? Do we still get a line in the log which states that?

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/dbdd3dac268e

Comment 8

[Jonathan Griffin (:jgriffin)]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> How would someone verify that a specific test has been ran? Do we still get
> a line in the log which states that?

Yes, you still see the usual Python unittest output.  In addition the TEST-START and TEST-END lines are still emitted via gecko's dump.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/15e19f1c53f9