810359 - [AccessFu] Introduce haptic presenter

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

In some occasions we would want to have the device to vibrate along with the regular aural feedback.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Introduce haptic feedback.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 680109 [details] [diff] [review]
Introduce haptic feedback.

Review of attachment 680109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

(I'm sort of wondering if pivotChanged should be renamed to something like pivotChangedResult)

::: accessible/src/jsat/AccessFu.jsm
@@ +326,5 @@
>        this._bridge.handleGeckoMessage(JSON.stringify({gecko: androidEvent}));
>      }
>    },
>  
> +  Haptic: function Haptic(aDetails, aBrowser) {

I'd probably put this before the Android section but up to you.

::: accessible/src/jsat/Presenters.jsm
@@ +383,5 @@
> +  __proto__: Presenter.prototype,
> +
> +  type: 'Haptic',
> +
> +  pivotChanged: function SpeechPresenter_pivotChanged(aContext, aReason) {

nit: HapticPresenter_pivotChanged

@@ +384,5 @@
> +
> +  type: 'Haptic',
> +
> +  pivotChanged: function SpeechPresenter_pivotChanged(aContext, aReason) {
> +    return { type: this.type, details: {pattern: [20]} };

nit: magic number (ok for now)

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 680109 [details] [diff] [review]
> Introduce haptic feedback.
> 
> Review of attachment 680109 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> (I'm sort of wondering if pivotChanged should be renamed to something like
> pivotChangedResult)
> 

Discussed this on IRC.

> ::: accessible/src/jsat/AccessFu.jsm
> @@ +326,5 @@
> >        this._bridge.handleGeckoMessage(JSON.stringify({gecko: androidEvent}));
> >      }
> >    },
> >  
> > +  Haptic: function Haptic(aDetails, aBrowser) {
> 
> I'd probably put this before the Android section but up to you.
> 

It is adjacent to the SpeechPresenter, which makes sense.

> ::: accessible/src/jsat/Presenters.jsm
> @@ +383,5 @@
> > +  __proto__: Presenter.prototype,
> > +
> > +  type: 'Haptic',
> > +
> > +  pivotChanged: function SpeechPresenter_pivotChanged(aContext, aReason) {
> 
> nit: HapticPresenter_pivotChanged
> 

Yup.

> @@ +384,5 @@
> > +
> > +  type: 'Haptic',
> > +
> > +  pivotChanged: function SpeechPresenter_pivotChanged(aContext, aReason) {
> > +    return { type: this.type, details: {pattern: [20]} };
> 
> nit: magic number (ok for now)

I'll make that an object attribute.

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/543413e0df70

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/543413e0df70