810586 - Collapsible table (wikipedia) not rendered correctly

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Jonathan]

Attachment: Table Incorrectly Rendered

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0
Build ID: 20121109030635

Steps to reproduce:

Go to http://en.wikipedia.org/wiki/Hundred_of_Hoo_Railway (Nightly 19.0a1 2012-11-09)


Actual results:

Collapsible table (showing diagram of railway line) has too much whitespace to right of table. When browser window is narrow, table intrudes over text.
Error not present on current Firefox (16.0.2).


Expected results:

Incorrect whitespace shouldn't appear - should render as in 16.0.2

Comment 1

[Loic]

(In reply to Jonathan from comment #0)
> Incorrect whitespace shouldn't appear - should render as in 16.0.2

I observe the same behavior with FF16 and FF19, the table "enters" into the text when the browser window is reduced horizontaly.

Comment 2

[Paul Silaghi, QA [:pauly]]

Thank you good fellows!
I confirm this wrong behavior on FF 19.0a1 (2012-11-12) on Win7 x64 when reducing the browser dimensions.
Setting the resolution to NEW.

Comment 3

[Stuart Orford]

Attachment: simplified testcase

I've reduced the problem to the attached testcase - it seems to be the combination of colspan and width=100% that causes each spanned column to be as wide as the content. Firefox 17, IE 9 and Chrome 23 fit the table to the text; in Firefox 18 the table is twice as wide.

Comment 4

[Jonathan]

Thanks Stuart, confirmed in Firefox 18 also - I've changed the branch to reflect this.

Comment 5

[Jonathan]

Also upped severity to major - Firefox 18 due for release w/c 6 Jan and this bug must affect a lot of webpages.

Comment 6

[Loic]

Regression range:

m-c
good=2012-09-07
bad=2012-09-08
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=36427d4b2cf6&tochange=1d4fc0c60063

Need more investigation.

Comment 7

[Matthias Versen [:Matti]]

I suspect bug 734569 but I'm currently bisecting

Comment 8

[Alice0775 White]

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0afb00f99006
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120907155516
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3916c4ac4a81
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120907160717
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0afb00f99006&tochange=3916c4ac4a81

Suspected :Bug 734569

Comment 9

[Matthias Versen [:Matti]]

The first bad revision is:
changeset:   104624:1ead7ec99cea
user:        L. David Baron <[e-mail]>
date:        Fri Sep 07 15:57:06 2012 -0700
summary:     Distribute the width of column-spanning cells to columns with nothi
ng in them, like we do for final table widths.  (Bug 734569)  r=dholbert

Comment 10

[bhavana bajaj [:bajaj]]

Considering where we are in the FF18 and this is not a very severe issue "wontfix" for FF18 & tracking it fir FF19 and above.:Dbaron, can you please help investigate  ?

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Please don't assign bugs directly to me without sending me email; I'm unlikely to notice.  (Really, I think that's true in general; you shouldn't change the assignee field without making sure that the assignee is actually aware of that.)

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: another simpified testcase

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: even simpler testcase

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: back out 734569 for beta

For beta I'd like to back out bug 734569.  It's pretty isolated from other changes so it should below risk to go back to the way things used to be; it's also not unlikely other occurrences of this same pattern will show up and break other pages.

(For trunk, patches coming shortly.)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 734569
User impact if declined: bad layout of Web pages
Testing completed (on m-c, etc.): it's our previous behavior
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 15

[bhavana bajaj [:bajaj]]

Comment on attachment 694439 [details] [diff] [review]
back out 734569 for beta

Approving the backout for FF18.Please make sure to perform the backout before Wednesday(12/26) .

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-beta/rev/931590387ec9

Still need to merge to b2g18.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/931590387ec9

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=d9f469a80bdb

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 694439 [details] [diff] [review]
back out 734569 for beta

At this point I'd also like to take the backout for Aurora.  Same
[Approval Request Comment] as before.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/637e063b2055

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1313ee568d60

Comment 22

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/637e063b2055

Comment 23

[Paul Silaghi, QA [:pauly]]

(In reply to Loic from comment #1)
> the table "enters" into the
> text when the browser window is reduced horizontaly.

This is still reproducible on Nightly 21.0a1 (2013-01-09), FF 19b1 on http://en.wikipedia.org/wiki/Hundred_of_Hoo_Railway, so the problem is not completely solved. See Chrome and Opera behaviors.

Comment 24

[u279076]

Can someone please advise based on comment 23? Should this bug be reopened? Should a follow-up bug be filed?

Comment 25

[Daniel Holbert [:dholbert]]

Yup, this still isn't quite right.

Testing w/ my nightly (2013-01-09), it looks like this part is fixed:
(In reply to Jonathan from comment #0)
> Collapsible table (showing diagram of railway line) has too much whitespace
> to right of table.

But this part is broken:
> When browser window is narrow, table intrudes over text.

We should probably track that in a followup, rather than trying to fix both issues in this bug.

Comment 26

[Paul Silaghi, QA [:pauly]]

(In reply to Daniel Holbert [:dholbert] from comment #25)
> Testing w/ my nightly (2013-01-09), it looks like this part is fixed:
> (In reply to Jonathan from comment #0)
> > Collapsible table (showing diagram of railway line) has too much whitespace
> > to right of table.
Verified fixed FF 18.0.1, 19b2, 20.0a2 (2013-01-22)

> But this part is broken:
> > When browser window is narrow, table intrudes over text.
> 
> We should probably track that in a followup, rather than trying to fix both
> issues in this bug.
bug 833788 filed