Closed
Bug 810680
Opened 12 years ago
Closed 11 years ago
add proper port number checking into the Account manager where missing
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.05 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
Add checks of validity of port number as is done for hostname in the account manager (bug 327812). Add a new function into hostnameUtils.jsm to check for port number validity. Make the textboxes taking a port number numeric and set proper range on them. This is already done on the mail server port and the LDAP server in addressbook, but is missing for SMTP server port.
Status: NEW → ASSIGNED
Summary: add proper port number checking into the Account manager and addressbook LDAP directory settings → add proper port number checking into the Account manager where missing
I couldn't find a place where to use the new function...
Attachment #743286 -
Flags: review?(iann_bugzilla)
(In reply to :aceman from comment #1) > Created attachment 743286 [details] [diff] [review] > patch > > I couldn't find a place where to use the new function... Well http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/sanitizeDatatypes.js#35 sort of does the job already.
Comment on attachment 743286 [details] [diff] [review] patch I rather, if there is nothing to use isValidPort, just not add that function. r=me with that function removed.
Attachment #743286 -
Flags: review?(iann_bugzilla) → review+
Thanks.
Attachment #743286 -
Attachment is obsolete: true
Attachment #752306 -
Flags: review?(mconley)
|
||
Updated•11 years ago
|
Attachment #752306 -
Flags: review?(mconley) → review+
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5731f3541e4e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•