811856 - [Keyboard] Should use 2 tones, one for input keys and one for function keys

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P3)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: Sounds

When a key is pressed there should be audio feedback. It would be great to have one tone for the keys and another for function keys like space, enter, shift, symbols and delete. See Attachment. I have 4 sound variations, these seemed to work best on device.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It feels like this bug has some collision with bug 811622

Comment 2

[Patryk Adamczyk [:patryk] UX]

(In reply to Vivien Nicolas (:vingtetun) from comment #1)
> It feels like this bug has some collision with bug 811622

When clarified Larissa just states to move it to a different screen. We shouldn't remove the sounds, just give the option to the user to disable them if they deemed them annoying.

Comment 3

[Casey Yee]

I just had a chat with Rudy and it looks like the sounds are in fact in place.   It should just be a matter of deciding if we want to have the setting enabled by default or not.

Also, the haptics are so delayed and low-quality they are more annoying than useful.  We should just remove it in my opinion.

Comment 4

[Kevin Grandon :kgrandon]

Has there been a decision made to remove or keep the sound? If we are keeping it - could we implement a single sound for all keys?

Comment 5

[Patryk Adamczyk [:patryk] UX]

The sound for keys is in, I believe its disabled by default. But I'd want there to be 2 sounds. Since we're post v.1, I'll change the title, to reflect the original request be fully fulfilled.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 7

[Eric Pang [:epang] UX]

Hi Casey, with Patryk on vacation, do you happen to know what the status of this bug is?

Comment 8

[Stephany Wilkes]

Swapped Casey out for Francis on the needinfo, as Francis and Josh are working on keyboard efforts now.

Comment 9

[Francis Djabri [:djabber]]

Hi Eric, 

Patryk followed up with Sam Joch and Sam said he'll be working on it this week.

Comment 10

[Eric Pang [:epang] UX]

(In reply to Francis Djabri [:djabber] from comment #9)
> Hi Eric, 
> 
> Patryk followed up with Sam Joch and Sam said he'll be working on it this
> week.

Great, thanks for letting me know Francis :)

Comment 11

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #10)
> (In reply to Francis Djabri [:djabber] from comment #9)
> > Hi Eric, 
> > 
> > Patryk followed up with Sam Joch and Sam said he'll be working on it this
> > week.
> 
> Great, thanks for letting me know Francis :)

Any updates for this bug Sam?  Francis mentioned you would be working on it last week.

Comment 12

[Sam Joch [:samjoch]]

Attachment: PR on Github

Branch: https://github.com/samjoch/gaia/tree/bug-811856-KeyboardShouldUse2TonesOneForInputKeysAndOneForFunctionKeys

Comment 13

[Patryk Adamczyk [:patryk] UX]

Great. Ship it.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 752170 [details]
PR on Github

One of the thing to consider would be put the |isSpecialKey| into |triggerFeedback()|, but that's not that important I guess.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/92b7375a6e0310a09fb2c2087b7b68b1cbfe94d3

Comment 16

[Eric Pang [:epang] UX]

Naoki, can you help verify?  Once verified we can flag for approval.  Thanks!

Comment 17

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified: 
## Environment :
"mozilla-central" path="gecko" revision="68760713a30f"
"gecko" revision="64b502c512a059c58da80924968136713fe6f8c3"
"gaia.git" revision="30f31d7dc5f81eb0c0e7980c44aad3b0a56f5a9c"
Build ID: 2013-06-13-03-08-19
MC/master build
Unagi

Verified... 

I am not sure if I understand the code, are we allocating new memory space for both sound bytes when any key is pressed?  I'm showing a lag if I type fast more so than before with the sound byte turned on.  I'm also worried about memory.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #17)
> I am not sure if I understand the code, are we allocating new memory space
> for both sound bytes when any key is pressed?  I'm showing a lag if I type
> fast more so than before with the sound byte turned on.  I'm also worried
> about memory.

Are you sure that the lag was introduced in this bug? If so please filing a bug so people could work on that. We might need to downgrade the bitrate of the files I think.