812332 - DetachAttachmentsWOPrompts crashes with empty string

Status: RESOLVED WORKSFORME

(MailNews Core :: Attachments, defect)

Description

[Kent James (:rkent)]

While debugging at attachment that calls DetachAttachmentsWOPrompts, TB crashes if this is called with non-zero count, but an empty aDisplayNameArray

Call stack in crash (from VS 2008):

 	msvcr90d.dll!strlen(unsigned char * buf=0x0026a098)  Line 81	Asm
 	xul.dll!nsCharTraits<char>::length(const char * s=0x00000000)  Line 590 + 0x9 bytes	C++
 	xul.dll!nsDependentCString::nsDependentCString(const char * data=0x00000000)  Line 57 + 0x12 bytes	C++
 	xul.dll!ConvertAndSanitizeFileName(const char * displayName=0x00000000, nsString & aResult={...})  Line 127 + 0x12 bytes	C++
>	xul.dll!nsMessenger::DetachAttachmentsWOPrompts(nsIFile * aDestFolder=0x09d9ee80, unsigned int aCount=0x00000001, const char * * aContentTypeArray=0x099aa0bc, const char * * aUrlArray=0x099aa0c0, const char * * aDisplayNameArray=0x099aa0c4, const char * * aMessageUriArray=0x099aa0dc, nsIUrlListener * aListener=0x0703b760)  Line 614 + 0x12 bytes	C++

Comment 1

[Wayne Mery (:wsmwk)]

/me not finding anything related on crash-stats

Comment 2

[Wayne Mery (:wsmwk)]

perhaps bp-79f91a96-644a-414c-8624-4e5e70190528 is an example?
xul.dll | nsMessenger::DetachAttachments

Comment 3

[Wayne Mery (:wsmwk)]

signatures are only seen in version 60 - and even then only 4 in the last 6 months https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=xul.dll%20%7C%20nsMessenger%3A%3ADetachAttachments&date=%3E%3D2019-07-19T14%3A27%3A00.000Z&date=%3C2020-01-19T14%3A27%3A00.000Z

I could be wrong, but => WFM