812345 - Downloads indicator button still resizes sometimes for some remaining download times.

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Demonstrating the problem

We fixed this on OSX, but it appears to be a problem on Windows too.

See screenshot.

We fixed it in OSX by reducing the font-size. We might be able to do the same here as well.

Comment 1

[Marco Bonardo [:mak]]

the progressbar also looks a bit low in the button, may you please verify the grid positioning with the arrow?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch on Windows 7

Strange that the top of the counter is 1/2 of a pixel off from the top part of the arrow. Don't ask me how that's possible - I'm really not sure.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch on Windows XP

Comment 5

[Marco Bonardo [:mak]]

(In reply to Mike Conley (:mconley) from comment #3)
> Strange that the top of the counter is 1/2 of a pixel off from the top part
> of the arrow. Don't ask me how that's possible - I'm really not sure.

subpixel antialiasing? We have fancy directdraw stuff on Win7.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 682548 [details] [diff] [review]
Patch v1

Review of attachment 682548 [details] [diff] [review]:
-----------------------------------------------------------------

I'm starting fearing this trend towards smaller font size, unfortunately the only way to properly tell if it hurts usability is using it for some time.
We may re-evaluate sizes when we have the final design of bug 801832, then the size will be less than an issue.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Landed in mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/68e26307643e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This was backed out while investigating a mess of orange that hit inbound all around the same time. It was re-landed once it was exonerated. Sorry for the churn.
https://hg.mozilla.org/integration/mozilla-inbound/rev/66450aee9446

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66450aee9446

Comment 10

[Mihai Morar, (:MihaiMorar)]

Based on my verifications done on FF 20.b1 and Latest Nightly 22.a1 this issue looks to be verified fixed.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130220104816)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130221 Firefox/22.0(20130221072044)