81237 - IRC Chat has bizarre menu position

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Matthew T (active 1999-2002)]

Build: 2001051504, Mac OS 9.1

To reproduce:
*   Open the `Tasks' menu.

What you see:

      Navigator             accel+1
      Mail/News             accel+2
      Composer              accel+4
      Address Book          accel+5
    ---------------------------------
      Privacy and Security          >
    ---------------------------------
      IRC Chat              accel+8
    ...

What you should see:

      Navigator             accel+1
      Mail/News             accel+2
      IRC Chat              accel+3
      Composer              accel+4
      Address Book          accel+5
    ---------------------------------
      Privacy and Security          >
    ---------------------------------
    ...

It makes no sense for the accel+3 `hole' to be empty, and for IRC Chat to be 
placed separately from the rest of the Mozilla apps with a seemingly-random 
accel+8 keyboard shortcut.

Comment 1

[Håkan Waara]

I think this "hole" is used for NS6.x for the AIM messenger or something...

Comment 2

[timeless]

bah, pinkerton or someone just closed this bug.

Comment 3

[Håkan Waara]

Attachment: fix

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

looks ok to me. sr=[e-mail]

Comment 5

[Håkan Waara]

reassign to self.

Comment 6

[Doron Rosenberg (IBM)]

r=doron

Comment 7

[Håkan Waara]

drivers emailed for approval.

Comment 8

[Asa Dotzler [:asa]]

does this break the commercail (IM?) menu overlay? 

Comment 9

[Håkan Waara]

Why would it?

Comment 10

[Håkan Waara]

I think NS should be fine if they hide the chatzilla menuitem by id=""... My
patch only moves the item to a new position

Comment 11

[Asa Dotzler [:asa]]

After talking with hwaara on IRC it looks like this should have zero impact on
the NS commercial menuitems. 
a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 12

[Håkan Waara]

Ok, so we hit some problems. Apparently, the Tasks menu automatically sets the
key (e.g., Ctrl+3) by the position of the menuitem. So because my fix changed
the position of the "IRC Client" item to position 3 - it also changed its key.

That means that for the Commercial builds, where they have the IM client as item
3 - if you have both IM and Chatzilla installed you'll get two menuitems with
the same key.

An easy workaround would be to set Chatzilla as item 6 (right after the
addressbook), but that wouldn't solve the key "hole" we are experiencing in
Mozilla builds.

Asa told me that Rob Ginda might be able to help out with a solution here. cc rginda

Comment 13

[Håkan Waara]

fixed

Comment 14

[sairuh (rarely reading bugmail)]

sorry for the delay...only recently returned to the trunk...in any case, the
current fix isn't good on commercial builds.

i'm reopening this --but let me know if it's best to keep this resolved and file
a separate bugscape report. perhaps IRC Chat shouldn't be built in the
commercial product for linux? [see results below --IRC Chat isn't present in the
mac or win32 comm bits, afaik. dunno why.]

results:

linux comm 2001.06.19.08 --both Tasks > IRC Chat and Tasks > Instant Messenger
have Ctrl+3. hitting Ctrl+3 brings up Instant Messenger.

winnt comm 2001.06.19.11 and mac comm 2001.06.19.08 --n/a: IRC Chat isn't listed
in the Tasks menu

Comment 15

[Håkan Waara]

I knew about this case when checking in, but got go-ahead from Asa, Ben, Kerz
and   Rginda because they said that Chatzilla is not installed by default anyway...

If you still want it fixed (probably you will) then file it as a separate
bugscape  report. Thanks

Comment 16

[sairuh (rarely reading bugmail)]

i've filed http://bugscape.mcom.com/show_bug.cgi?id=6615 so that chatzilla
doesn't get into the commercial bits like that.

re-resolving as fixed. thx, hakan!

Comment 17

[Matthew T (active 1999-2002)]

In build 2001062105 (yeah, I know it's old, but it's from a long time after 
this bug was fixed), on Mac OS 9.1, I have the following:

      Navigator             accel+1
      Mail/News             accel+2
      Composer              accel+4
      IRC Chat              accel+3
      Address Book          accel+5

Close, but no cigar. Reopening.

Comment 18

[Håkan Waara]

On build 20010620 (the day before mpt's build was made), it is correct. Has been
working for me ever since the checkin was done...

Comment 19

[Asa Dotzler [:asa]]

hwaara, I think that this has been wrong on mac and right on win32 and linux. 

Comment 20

[Håkan Waara]

But how? chatzillaOverlay.xul is XP

Comment 21

[Håkan Waara]

Can anyone else on Mac confirm this behaviour?

Comment 22

[sairuh (rarely reading bugmail)]

yep, i'm seeing what mpt saw using 2001.07.03.10-trunk mozilla bits on mac.

Comment 23

[Håkan Waara]

Pinkerton, you're XPMenu and Mac master. Any idea why this *can* be happening? 
I didn't think these things were able to happen in XP code.

Comment 24

[Håkan Waara]

I have no idea at all how to fix this mac-only bug (works just fine on Linux and
Windows). I'm sorry. :(

I'll reassign this to XPApps.

Comment 25

[Paul Chen]

Umm, 2001-08-13-06-trunk mac classic build seems fine and my opt mac classic
build from trunk a few days ago looks ok, too. Marking fixed

Comment 26

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.11.06.08-mozilla bits on mac os 10.1 --IRC Chat [cmd+3] is
properly btwn Mail & Newsgroups [cmd+2] and Composer [cmd+4] in the Tasks menu.

Comment 27

[Matthew T (active 1999-2002)]

Reopening. Both 2001112708 on Mac OS, and 0.9.6 on Windows, have the `IRC Chat'
item as the fifth (last) item in the group, when it should be the third.

Comment 28

[Asa Dotzler [:asa]]

-> default assignee

Comment 29

[Peter Trudelle]

poss. infrastructure bug? ->xpt menus

Comment 30

[nnooiissee]

this is fixed with the patches in bug 109598. i think andreww is going to review
when he gets back. he said he owns a bugscape bug which should be fixed by that
as well.

if anyone wants to r/sr the patches in bug 109598, feel welcome to.

btw, the underlying problem is that different ports seem to load components in
different orders. most load messanger first, then chatzilla, but mac os classic
(not x) loads chatzilla first. nasty little situation, but the solution is to
ignore it and not to use position=.

Comment 31

[Håkan Waara]

.

Comment 32

[Håkan Waara]

Fixed.