813031 - gDevTools needs an API review [toolbox]

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Joe Walker [:jwalker]]

We noticed 2 things while creating gDevTools:
- the ``isReady | once("ready")`` thing could be better through use of promises
- toggleToolboxCommand should be moved off gDevTools

Comment 1

[Paul Rouget [:paul]]

From https://github.com/joewalker/devtools-window/issues/108#issuecomment-11037780

> We might need to cleanup a bit Toolbox. For example, we expose frame and doc. I don't think we need these properties.
> (by exposing, I mean not prefixing the property with _)

Comment 2

[Rob Campbell [:rc] (:robcee)]

what was "landed" in fx-team?

Comment 3

[Joe Walker [:jwalker]]

Attachment: as pushed

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff

Comment 5

[Joe Walker [:jwalker]]

Review took place here: https://github.com/joewalker/devtools-window/pull/324

Comment 6

[Wladimir Palant]

Just in case somebody else is trying to figure out when these API changes took place: they landed with http://hg.mozilla.org/mozilla-central/rev/fea63da9e80c and were released with Firefox 20 if my calculations are correct.