Closed Bug 813062 Opened 12 years ago Closed 10 years ago

Tapping on Clock does not take user to clock app.

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: pabloUX, Assigned: crdlc)

References

Details

(Whiteboard: interaction)

Attachments

(1 file, 2 obsolete files)

* Environment: Unagi, build (dev) from Friday 16 Nov.
* Repro: Browse to landing page, tap on clock. Nothing happens.
* Expected: Tapping on clock in landing page will invoke the Clock app.
* Actual: Nothing happens. User stays in landing page.
Whiteboard: Interaction design
Assignee: nobody → crdlc
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached file Patch v1 (obsolete) —
Attachment #684370 - Flags: review?(21)
I'm not convinced that it should. We don't support widgets in v1, and don't want to train users to expect them in this or future releases. Clock app is not so vital that it needs a huge access shortcut. cc'ing Ricardo for input.
Summary: [Home/IxD]: Tapping on Clock does not take user to clock app. → Tapping on Clock does not take user to clock app.
Whiteboard: Interaction design → interaction
Comment on attachment 684370 [details]
Patch v1

Removing review until a UX decision has been taken.
Attachment #684370 - Flags: review?(21)
Just talked with Josh and agreed to go ahead and make the clock area in landing page clickable. Please Vivien, Cristian, go ahead with submission and revision.

Thank you guys!

Ricardo
Attachment #684370 - Flags: review?(21)
I've tested the pull request and it continues working :)
Comment on attachment 684370 [details]
Patch v1

I really feel uncomfortable with hardcoding the clock application url in the homescreen application. If the user install a new clock he will never we able to access it with this link. That does not sounds right.
Attachment #684370 - Flags: review?(21) → review-
I don't like that but that appears in master. Well, How could we do it? Implementing an activity in the clock app?

"activities": {
    "view": {
      "filters": {
        "type": "time"
      }
    }
Attached file Patch v2 (obsolete) —
Attachment #684370 - Attachment is obsolete: true
Attachment #700365 - Flags: review?(21)
Attached file Patch v3
Attachment #700365 - Attachment is obsolete: true
Attachment #700365 - Flags: review?(21)
Attachment #700367 - Flags: review?(21)
(In reply to crdlc from comment #8)
> I don't like that but that appears in master. Well, How could we do it?
> Implementing an activity in the clock app?
> 
> "activities": {
>     "view": {
>       "filters": {
>         "type": "time"
>       }
>     }

I'm like you I don't like to have to do an activity for such things...
sorry but I don't have more ideas :)

1) No hardcoded, I agree that was a shit :) jejjeje
2) As activity...

Do you have any suggestion to run the clock app?

Thanks
Did you forget this pr? :)
Flags: needinfo?(21)
Comment on attachment 700367 [details]
Patch v3

I still think this is the wrong way to do it but I don't have any good suggestions.
Attachment #700367 - Flags: review?(21) → review-
Flags: needinfo?(21)
While we think about it, we could open other bug in order to fix this:

[JavaScript Error: "ReferenceError: Applications is not defined" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 3}]

So we could remove from

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.js#L27

to 

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.js#L33

Are you agree?
Flags: needinfo?(21)
(In reply to crdlc from comment #15)
> While we think about it, we could open other bug in order to fix this:
> 
> [JavaScript Error: "ReferenceError: Applications is not defined" {file:
> "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 3}]
> 
> So we could remove from
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.
> js#L27
> 
> to 
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/landing.
> js#L33
> 
> Are you agree?

Sure. That sounds good to me.
Flags: needinfo?(21)
It doesn't make sense anymore
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: