Closed
Bug 81308
Opened 23 years ago
Closed 23 years ago
Chrome scripts silently fail to load with when they contain syntax errors
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: bugzilla, Assigned: sfraser_bugs)
Details
(Keywords: regression, smoketest)
Scripts referenced from chrome are failing to load. I saw this in one case and so did Boris, and Doron saw it another. This is blocking a lot of work. Trying to narrow it down now.
Reporter | ||
Comment 1•23 years ago
|
||
To clarify, it's just some scripts. We haven't figured out the pattern yet.
Summary: Scripts are failing to load → Some scripts are failing to load
Comment 2•23 years ago
|
||
here is what I see (cvs pull from yesterday): I load 2 .js (navigator.js and viewsource.js) files in a .xul. However, only the first one seems to be actually loaded, as calling functions from the 2nd one did nothing. Changing the order had the effect that only functions in the first one were accesible. bz was unable to see this with the same .xul, which leads me to think that my hacked viewsource.js is at fault. Working on a simplified testcase.
Keywords: regression
Comment 3•23 years ago
|
||
Just to rule out bug 74883, now fixed, could you guys who have builds update js/src/jsdhash.c and xpcom/ds/pldhash.c, and rebuild incrementally (if you have good dependencies)? /be
Comment 4•23 years ago
|
||
BTW, I'd expect crashes from 74883, not this -- so I'm pretty sure it won't help but I wanted to mention it. /be
Comment 5•23 years ago
|
||
brendan/hyatt don't see this. go clobber, marking critical to get off blocker list.
Severity: blocker → critical
Comment 6•23 years ago
|
||
Blake, did you see this with today's release build? (2001-05-16-10-trunk or 2001-05-16-12-trunk)
Comment 7•23 years ago
|
||
I've narrowed it down to a syntax error in the script that blake was seeing it on (missing comma between items in the prototype section). So what I'm seeing is this: If there's a syntax error in a script, the script fails to load, no code in it is executed (I had an alert() at the very beginning) and there is nothing in the JS console to indicate what's wrong.
Severity: critical → blocker
Reporter | ||
Comment 9•23 years ago
|
||
Why would "clobber and try again" be a likely solution when three different people are seeing the problem? I think this should be a blocker again because it's a major problem and is probably causing many other bugs.
Summary: Some scripts are failing to load → Scripts fail to load when they contain syntax errors
Reporter | ||
Comment 10•23 years ago
|
||
Upgrading this to blocker again because this is causing or probably will cause other bugs that we shouldn't waste time tracking down. Aside from the fact that js errors are no longer output to the console, the js errors in the problematic file(s) aren't even reported by the jseng, nor is there any indication that they are failing to load. So there's no easy way to tell when this bug is biting you.
Severity: critical → blocker
Reporter | ||
Comment 11•23 years ago
|
||
Ok, talked to the sheriff, we'll re-evaluate this before tree opening tomorrow in light of verifications.
Severity: blocker → critical
Comment 12•23 years ago
|
||
I'm sorry, but this is not a bug, this is just the way script loading works, and always has worked, and always will work. The same issue exists when webpages load script files, if the file contains *syntax* errors, the file is not loaded and *no* part of the script is executed, this is how all browsers work, AFAIK (verified in Mozilla and IE). INVALID.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 14•23 years ago
|
||
INVALID.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → INVALID
Comment 15•23 years ago
|
||
Johnny, the issue here is not that the scripts fail to load. That's fine. The problem is that the JS console contains no indication of the failure (for web content it shows the syntax error and the line the error occured on, for chrome it does not). This leads to mysterious failures in loading chrome scripts and makes such failures very hard too debug. Some error reporting would be immensely helpful. Reopening and adjusting summary to reflect the real problem.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: Scripts fail to load when they contain syntax errors → Chrome scripts silently fail to load with when they contain syntax errors
Assignee | ||
Comment 16•23 years ago
|
||
This is killing me right now...
Assignee | ||
Comment 17•23 years ago
|
||
I'm seeing silent failure on script compilation; there is no error reporter set on script context that the nsXULDocument is using.
Assignee | ||
Comment 18•23 years ago
|
||
The XPCDOM landing broke this. nsJSContext::InitContext() is bailing at the if (!aGlobalObject) clause, so we never get down to the code that sets the error reporter.
Assignee | ||
Comment 19•23 years ago
|
||
Patch: Index: mozilla/dom/src/base/nsJSEnvironment.cpp =================================================================== RCS file: /cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v retrieving revision 1.137 diff -b -u -2 -r1.137 nsJSEnvironment.cpp --- nsJSEnvironment.cpp 2001/05/15 22:26:18 1.137 +++ nsJSEnvironment.cpp 2001/05/18 02:29:01 @@ -1031,4 +1031,6 @@ } + ::JS_SetErrorReporter(mContext, NS_ScriptErrorReporter); + if (!aGlobalObject) { // If we don't get a global object then there's nothing more to do here. @@ -1065,6 +1067,4 @@ rv = InitClasses(); // this will complete global object initialization NS_ENSURE_SUCCESS(rv, rv); - - ::JS_SetErrorReporter(mContext, NS_ScriptErrorReporter); mIsInitialized = PR_TRUE; This allows me to find JS errors again. Not sure if it's totally correct (there is some other stuff at the bottom of Init() that looks like it should happen if aGlobalObject is NULL.
Comment 20•23 years ago
|
||
this bug just bit me, I've changed my mind, this is now a blocker.
Severity: critical → blocker
Comment 21•23 years ago
|
||
Thanks for the patch, Simon, and I'm sorry for not realizing that this really was a problem earlier, fix checked in (and yes, the fix is good).
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla0.9.1
Updated•23 years ago
|
QA Contact: lchiang → stummala
Updated•14 years ago
|
Assignee: jst → sfraser_bugs
Component: DOM: Abstract Schemas → DOM
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•