813100 - Dock should not be present at everything.me panel. Animate it to go away

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P3)

Comment 1

[Josh Carpenter [:jcarpenter]]

Need to fix this for release.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Hey Josh, Ami will contact you about this.

Comment 3

[Cristian Rodriguez (:crdlc)]

Should we implement it or not? thanks

Comment 4

[Josh Carpenter [:jcarpenter]]

I spoke with Ami today and we're going to revisit this and a few other items next week, so hold off for now, and I will follow up.

Comment 5

[Dylan Oliver [:doliver]]

Josh, any update on this one?

Comment 6

[David Scravaglieri [:scravag]]

Not have to be a smoketestblocker

Comment 7

[Chris Lee [:clee]]

Josh, what's the latest thinking here?

Comment 8

[Josh Carpenter [:jcarpenter]]

Let's hide the dock. The thinking from the TEF + Moz UX teams is unanimous on this one.

* In v1 we want to increase the contrast between the "two worlds" of E.me versus the installed-apps grid
* We also want to maximize the available vertical real estate for the categories

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

No problem. We'll have a pull request ready soon.

Comment 10

[Chris Lee [:clee]]

Agree, hiding makes sense here.  Thanks.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It works well now. Every changes to the homescreen is a risk so I won't block on this.

Comment 12

[Josh Carpenter [:jcarpenter]]

Renoming. Ran said "no problem", and UX team feels strongly that this needs to be reverted back to the original implementation for usability reasons. This is one we're going to fight for.

Comment 13

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Make sure the OS dock is kept hidden across all Ev.me

Comment 14

[Cristian Rodriguez (:crdlc)]

the code is ok, although I have a thought. In previous version in the first view with the dock, the categories had a specific viewport, now it should be bigger because the dock is hidden. We have more space for categories with this change but I don't see any change in CSS

Comment 15

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/8731bc824ebcb7ec5503725aaaa3d3e3745fe9a9

Comment 16

[Josh Carpenter [:jcarpenter]]

(In reply to crdlc from comment #14)
> the code is ok, although I have a thought. In previous version in the first
> view with the dock, the categories had a specific viewport, now it should be
> bigger because the dock is hidden. We have more space for categories with
> this change...

Agreed. The dock hiding should open up the screen for more E.me results.

Comment 17

[Ran Ben Aharon [:ranbena] EverythingMe]

The extra space is already implemented.

Brain.FFOS.showMenu() that was removed in this commit triggered a className change that minimised the shortcuts container area. https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Shortcuts/Shortcuts.css#L42

Comment 18

[Misty Byrd]

This issue fixed for  device Ungia; build #20130103070201 v.1