Closed
Bug 813373
Opened 12 years ago
Closed 12 years ago
make all style rule classes have useful List methods
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(3 files)
5.34 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
4.04 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
8.26 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
While debugging bug 780692, nrc got confused by the style context dumps because some style rules don't implement a List method, which means that there are hidden rules in the list of rules that the style context represents. All of our rules should have useful list methods; I'll attach a patch series to fix that.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #683370 -
Flags: review?(dholbert)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #683371 -
Flags: review?(dholbert)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #683372 -
Flags: review?(bzbarsky)
Updated•12 years ago
|
Attachment #683370 -
Flags: review?(dholbert) → review+
Updated•12 years ago
|
Attachment #683371 -
Flags: review?(dholbert) → review+
Comment 4•12 years ago
|
||
Comment on attachment 683372 [details] [diff] [review] , patch 3: Make sure all style rules have non-empty List implementations. r=me
Attachment #683372 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•12 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e4b30b1d10 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf88ae52c5b remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/da575e9f17c4
Comment 6•12 years ago
|
||
Comment on attachment 683372 [details] [diff] [review] , patch 3: Make sure all style rules have non-empty List implementations. Review of attachment 683372 [details] [diff] [review]: ----------------------------------------------------------------- Sorry I'm a bit late to the party, but should the printfs in this patch be fprintf/fputs?
Assignee | ||
Comment 7•12 years ago
|
||
Er, indeed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f59f962f0b5c
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a6e4b30b1d10 https://hg.mozilla.org/mozilla-central/rev/cbf88ae52c5b https://hg.mozilla.org/mozilla-central/rev/da575e9f17c4 https://hg.mozilla.org/mozilla-central/rev/f59f962f0b5c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•