813551 - [settings] SIM Toolkit should be disabled if no SIM is present

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[Josh Carpenter [:jcarpenter]]

Agreed.

Comment 2

[Josh Carpenter [:jcarpenter]]

Pablo, can you confirm that this is still a problem? 

If it is, what happens when the Toolkit appears? Can the user simply cancel out of the process? Can you please decide whether to mark this UX-P2 ("should fix for release") or UX-P3 ("want to fix for release"). And if it's UX-P2, can you decide whether to nominate for basecamp-blocking?

Thanks,

Comment 3

[Walter Chen[:ypwalter][:wachen]]

2012-1-7 b2g18(v1.0) build from pvt server
unagi

STR:
  0. Turn on your phone with SIM card
  1. Make sure ur phone connected to the tele network
  2. Turn off the phone
  3. Take out the card and restart
  4. Go to "Settings" and slide all the way down

expected result: 
   No SIM card toolkit shown

actual result:
   SIM card toolkit shown

That's not good at all. You think you closed the data roaming, but it actually doesn't get closed.

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Remove cached data on startup

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 699091 [details] [diff] [review]
Remove cached data on startup

I just tried and the only side effect is that SIM Toolkit menu will not launch any command. It's not ideal but I won't hold v1 and there are many others issues to fight on before this one.

Please note that I'm not r- the code, just not giving approval to land it on master.

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> Comment on attachment 699091 [details] [diff] [review]
> Remove cached data on startup
> 
> I just tried and the only side effect is that SIM Toolkit menu will not
> launch any command. It's not ideal but I won't hold v1 and there are many
> others issues to fight on before this one.
> 
> Please note that I'm not r- the code, just not giving approval to land it on
> master.

Yes, this only happens in two cases:

1.- You extract a SIM card which uses STK and no other SIM card is plugged, so the handset without SIM will show the STK menu with the last cached one

2.- After 1, you insert another SIM card, but this one WITHOUT STK enabled, so since this SIM card didn't sent any STK Proactive command the menu is not updated so you plugged an Carrier1 card and in settings you see the Carrier2 menu and title string.

The bad thing: a non-useful menu showed and "scared" :D user calling client relationship of Carrier1 asking what happens?

3.- If after 1 you insert a SIM card with STK enabled, the menu will be updated, anyway if the user goes to settings TOO FAST (near 0) he can see the previous menu for a little amount of seconds until it is updated.

--

So mainly, this is a UX fix

Comment 8

[David Scravaglieri [:scravag]]

Please renominate if needed.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

Renoming as the duplicated bug 829374 is causing certification failures

Comment 10

[Marcelino Veiga Tuimil [:sonmarce]]

Besides, there is already a low risk patch

Comment 11

[Daniel Coloma:dcoloma]

Vivien, given that it seems to be a certification failure as stated in comment 9, could you review the patch?

Comment 12

[Faramarz Rashed]

based on partner feedback this is becoming a tef+.  please review the patch and if technically correct let it land before 1/15.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 699091 [details] [diff] [review]
Remove cached data on startup

Review of attachment 699091 [details] [diff] [review]:
-----------------------------------------------------------------

What about simply checking the card state status in the settings app and hide/disabled the SIM Toolkit row if needed?

Comment 14

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #13)
> Comment on attachment 699091 [details] [diff] [review]
> Remove cached data on startup
> 
> Review of attachment 699091 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> What about simply checking the card state status in the settings app and
> hide/disabled the SIM Toolkit row if needed?

Because that will fix if NO SIM card is plugged, but if you plug a SIM card without STK app the code will detect a SIM card and will show the previous card cached menu.

Since the STK menu is only sent by STK powered SIM cards on startup we'll receive it each time the handset is turned on, so we only need to cache this data on startup. If no STK is supported cause no SIM card plugged or no STK card powered no proactive command will be received.

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Fernando R. Sela [:frsela] from comment #14)
> (In reply to Vivien Nicolas (:vingtetun) (:21) from comment #13)
> > Comment on attachment 699091 [details] [diff] [review]
> > Remove cached data on startup
> > 
> > Review of attachment 699091 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > What about simply checking the card state status in the settings app and
> > hide/disabled the SIM Toolkit row if needed?
> 
> Because that will fix if NO SIM card is plugged, but if you plug a SIM card
> without STK app the code will detect a SIM card and will show the previous
> card cached menu.
> 

That makes sense.

Comment 16

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Thanks.

PR:https://github.com/mozilla-b2g/gaia/pull/7643
Landed: https://github.com/mozilla-b2g/gaia/commit/232213506baff5ce549237943e612c42db3f4d7c

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified fixed: 
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia   6c3767c2dea43b5e9aff7d156d36d69649005621
BuildID 20130320070206
Version 18.0

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia   1438da6ca0e020a8df686e2100a668370dfe6fb6
BuildID 20130312230202
Version 18.0