Closed Bug 813576 Opened 12 years ago Closed 7 years ago

Use context managers in automation.py

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: emorley, Unassigned)

Details

Broken out from bug 808410.

(In reply to Gregory Szorc [:gps] from comment #21)
> Comment on attachment 681926 [details] [diff] [review]
> Part 5: Callers of checkForCrashes should use its return value
...
> ::: build/automation.py.in
> @@ +1075,5 @@
> >      if os.path.exists(processLog):
> >        os.unlink(processLog)
> >  
> >      if self.IS_TEST_BUILD and runSSLTunnel:
> >        ssltunnelProcess.kill()
> 
> This script looks like it could use some context manager love!
We moved all the useful bits out of automation.py into mozbase.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.