813828 - Allow chrome code to launch Web Activities

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

Since bug 794407 we restrict web activities to be only launchable by user input. This breaks all use of web activities from chrome code such as protocol and content handlers.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch v2

Simpler patch using nsContentUtils::IsChromeDoc

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 683854 [details] [diff] [review]
patch v2

Review of attachment 683854 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the printf_stderr removed.

::: dom/activities/src/Activity.cpp
@@ +55,5 @@
> +  nsCOMPtr<nsIDocument> document = do_QueryInterface(window->GetExtantDocument());
> +
> +  if (!nsEventStateManager::IsHandlingUserInput() &&
> +      !nsContentUtils::IsChromeDoc(document)) {
> +    printf_stderr("!! Can start activity from non user input or chrome code.");

Could you remove this printf_stderr, please? :)

Feel free to write another patch to show something in the console, though. I think that would be handy for developers :)

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ae5ff606cf2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ae5ff606cf2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/871f22673ad8
https://hg.mozilla.org/releases/mozilla-beta/rev/bc5914b106a4

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 683854 [details] [diff] [review]
patch v2

Review of attachment 683854 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/activities/src/Activity.cpp
@@ +51,5 @@
>    NS_ENSURE_TRUE(window, NS_ERROR_UNEXPECTED);
>  
>    Init(window);
>  
> +  nsCOMPtr<nsIDocument> document = do_QueryInterface(window->GetExtantDocument());

window->GetExtantDoc()

@@ +55,5 @@
> +  nsCOMPtr<nsIDocument> document = do_QueryInterface(window->GetExtantDocument());
> +
> +  if (!nsEventStateManager::IsHandlingUserInput() &&
> +      !nsContentUtils::IsChromeDoc(document)) {
> +    printf_stderr("!! Can start activity from non user input or chrome code.");

NS_NAMED_LITERAL_STRING