814061 - BaselineCompiler: Fix x64 test failures

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Tom S [:evilpie]]

Attachment: v1

JIT test failures left over are.

    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/arguments/args-mochi.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/argumentsOptimize-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/testSetElem-Indexed.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/bug671943-2.js
    --ion-eager /home/tom/ionmonkey/js/src/jit-test/tests/jaeger/recompile/memory-01.js

The first two are also failing on x86. The third one is recent. The fourth one depends on an gc(); call.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 684075 [details] [diff] [review]
v1

Review of attachment 684075 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 3

[Tom S [:evilpie]]

http://hg.mozilla.org/projects/ionmonkey/rev/37ad58ffe32b

Comment 4

[Paul Wright]

Can this be closed or turned into a meta?

Comment 5

[Kannan Vijayan [:djvj]]

I'm thinking we can keep this open for fixing ongoing test failures that show up on x64 as development proceeds.

Comment 6

[Jan de Mooij [:jandem]]

All green now.