8143 - Cannot set wrapColumn until the editor has been instantied

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Jean-Francois Ducarroz]

in my java script, if I try to set the wrapColumn right after setting the editor
type, it failed because the editor hasn't been instantied yet. The problem is
that I cannot set it later because I don't know when the editor will be ready
for it!

in msgComposeCommands.js:

window.editorShell.SetEditorType("text");
window.editorShell.wrapColumn = msgCompose.wrapLength;

Look's like that the auto wrapping will be broken for M7

Comment 1

[Simon Fraser [no longer active]]

Yes, we need a way for the editorShell to store values that must be set
in the editor once the editor has been instantiated. Should be pretty easy.

Is this a blocker, or a must-fix for M7?

Comment 2

[lchiang]

Would be nice to fix for M7.  Right now, I can continue typing in the html mail
compose window, but the text doesn't wrap to the next line; instead I see the
scroll bar although the window doesn't scroll as I type.  Other symptoms
include: wrapping at strange places so that the text looks like:

this is a test
here is some more text - this part should have been on line 1

Tried this on 6/14 builds of Win32 and Linux.  Have not tried Mac yet.

Comment 3

[Akkana Peck]

Sadly, I won't be able to commit to fix these in time for M8; we've had a huge
flood of regressions in the last few days and I'll need to spend my time on
tracking down where the bustage happened.

Comment 4

[Akkana Peck]

A fix has been checked in; now the editor shell should store the wrap column
until the editor is created.

Comment 5

[pmock]

Auto wrap is working in the composer editor but not in mail.  I logged a
separate bug 12320 on the mail issue.

For this bug, I verified that in the composer, the wrap column does work.  I
tested it in the following M9 builds:
  Win32 seamonkey 1999-08-16-09-m9 and 1999-08-20-16-m9 builds
  Linux seamonkey 1999-08-16-08-m9 build
  MacOS seamonkey 1999-08-20-16-m9 build.

Marking this bug verified for the composer editor.