814618 - B2G STK: STK DisplayText Command not working properly with coding scheme is GSM 7 bit packed.

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Tuenti has a STK USSD command to query the balance.

Since in Android is working properly, in B2G is not recovering it well.

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Log with RIL DEBUG activated

Log calling the STK USSD command to query balance.

At 11-23 10:18:18.789 the STK app had been opened
At 11-23 10:18:30.999 the STK command balance query had been selected
At 11-23 10:18:32.879 received the bad response "Sald" instead "Saldo 2.28 E. Validex 20/05/13."

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Screenshot with the correct response in Android

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Screenshot with the bad response in Unagi

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 684626 [details]
Log with RIL DEBUG activated

yeah, thanks for reporting this.
I'll fix it.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Read GSM 7 bit packed string.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: xpcshell tests

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

somehow I got compile error when I am trying to build emulator, will upload marionee tests later.

Comment 8

[Andrew Overholt [:overholt]]

Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: marionette test for Display Text with GSM 7 bit encoding.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 688149 [details] [diff] [review]
Part 3: marionette test for Display Text with GSM 7 bit encoding.

Review of attachment 688149 [details] [diff] [review]:
-----------------------------------------------------------------

Finally, first Marionette based STK test case :)
The pendingEmulatorCmdCount thing has to be corrected.

::: dom/icc/tests/marionette/test_stk_proactive_command.js
@@ +8,5 @@
> +let icc = navigator.mozMobileConnection.icc;
> +
> +function verify() {
> +  ok(icc);
> +  ok(icc instanceof MozIccManager, "icc is instanceof " + icc.constructor);

You don't have to check ok(icc) because the next line is enough. Then, you don't need verify() function here because it will have only one check inside. You can simply do:

  let icc = navigator.mozMobileConnection.icc;
  ok(icc instanceof MozIccManager, "icc is instanceof " + icc.constructor);

@@ +21,5 @@
> +  runNextTest();
> +}
> +
> +let tests = [
> +  {command: "d0288103012180820281020d1d00d3309bfc06c95c301aa8e80259c3ec34b9ac07c9602f58ed159bb940",

I guess nobody but you can ever understand this string.

@@ +33,5 @@
> +    return;
> +  }
> +
> +  let cmd = "stk pdu " + test.command;
> +  runEmulatorCmd(cmd, function (result) {

Please have something like:

  let pendingEmulatorCmdCount = 0;
  function sendStkPduToEmulator(pdu) {
    ++pendingEmulatorCmdCount;

    let cmd = "stk pdu " + pdu;
    runEmulatorCmd(cmd, function (result) {
      --pendingEmulatorCmdCount;
    });
  }

  function cleanUp() {
    if (pendingEmulatorCmdCount) {
      window.setTimeout(cleanUp, 100);
      return;
    }

    // Real clean ups
  }

Or it will have problems when multiple emulator commands were sent.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: marionette test for Display Text with GSM 7 bit encoding. v2

Addressed to Vicamo's comments,

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: marionette test for Display Text with GSM 7 bit encoding. v2

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 688680 [details] [diff] [review]
Part 3: marionette test for Display Text with GSM 7 bit encoding. v2

Addressed to Vicamo's comments.

Comment 14

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 688680 [details] [diff] [review]
Part 3: marionette test for Display Text with GSM 7 bit encoding. v2

Review of attachment 688680 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget r=me before commit :)

Comment 15

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Read GSM 7 bit packed string.

add r=vicamo

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: xpcshell tests for Display Text. r=vicamo

add r=vicamo

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: marionette test for Display Text with GSM 7 bit encoding. v2

add r=vicamo

Comment 19

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/083715f2116c
https://hg.mozilla.org/integration/mozilla-inbound/rev/0def12e6e4a7
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd845cbfc76e

Comment 20

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/083715f2116c
https://hg.mozilla.org/mozilla-central/rev/0def12e6e4a7
https://hg.mozilla.org/mozilla-central/rev/cd845cbfc76e

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/206dc6384dd5
https://hg.mozilla.org/releases/mozilla-aurora/rev/2831e3200fae
https://hg.mozilla.org/releases/mozilla-aurora/rev/0e7b801ff250

https://hg.mozilla.org/releases/mozilla-beta/rev/40d04d4c7b96
https://hg.mozilla.org/releases/mozilla-beta/rev/b40672524071
https://hg.mozilla.org/releases/mozilla-beta/rev/e5d5f35b3e82

Comment 22

[mbarone]

Tested with the build

Gecko-cb6ee76.Gaia-16006ea and works fine. I'm able to check the balance with the Tuenti SIM card

Comment 23

[Mozilla RelEng Bot]

Try run for de3acda765ca is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=de3acda765ca
Results (out of 313 total builds):
    exception: 1
    success: 284
    warnings: 26
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-de3acda765ca