Closed
Bug 814739
Opened 12 years ago
Closed 12 years ago
rename gMsgCompose in addressbook-panel.js to something unique
Categories
(SeaMonkey :: Sidebar, defect)
SeaMonkey
Sidebar
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.17
People
(Reporter: mnyromyr, Assigned: ewong)
Details
(Whiteboard: [good first bug][lang=js][mentor=IanN])
Attachments
(1 file)
|
2.35 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
In addressbook-panel.js, we define a global boolean variable gMsgCompose. In MsgComposeCommands.js, we define a global object variable gMsgCompose. While both variable scopes don't mix, it's plain confusing – given that about 86/94 of the current usages mean the latter … Thus, we should rename the former.
|
||
Updated•12 years ago
|
Whiteboard: [good first bug][lang=js][mentor=IanN]
|
||
Comment 1•12 years ago
|
||
Yeah, that was my fault, I just couldn't be bothered to type gThisSidebarPanelIsInAMsgComposeWindow.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 693794 [details] [diff] [review] Rename patch. (v1) Looks good r=me
Attachment #693794 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/d0cff14ac3c3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in
before you can comment on or make changes to this bug.
Description
•