814786 - Focusing an element inside the location bar (e.g. notification icons, identity icon) removes domain highlighting

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[M8R-p7]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0
Build ID: 20121121030712

Steps to reproduce:

Visit a site that will prompt you with a Notification icon in the URLbar. The plugins.click_to_play feature gives the cleanest examples, as it presents no messages until clicked.


Actual results:

Clicking the Notification icon in the URLbar removes domain highlighting from the current URL. It is not reinstated once the notification has been closed.


Expected results:

Domain highlighting should be unaffected.

Comment 1

[Alice0775 White]

I can reproduce
http://hg.mozilla.org/mozilla-central/rev/d8e4f06198dc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0 ID:20121123030827

Comment 2

[Alice0775 White]

Clicking password-notification-icon also removes the domain highlight.

Comment 3

[Alice0775 White]

Regression window
Good:
http://hg.mozilla.org/mozilla-central/rev/43949eb48546
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110512 Firefox/6.0a1 ID:20110512101326
Bad:
http://hg.mozilla.org/mozilla-central/rev/2601f4d06ffe
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110512 Firefox/6.0a1 ID:20110512144531
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=43949eb48546&tochange=2601f4d06ffe

Regressed by: Bug 654729

Comment 4

[Alice0775 White]

WORKAROUND:

#notification-popup-box *{
-moz-user-focus:ignore  !important;
}

Comment 5

[Alice0775 White]

(In reply to Alice0775 White from comment #4)
> WORKAROUND:
> 
> #notification-popup-box *{
> -moz-user-focus:ignore  !important;
> }

Aha,this workaround breaks tab key navigation(Bug 572967).

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 684967 [details] [diff] [review]
patch

Review of attachment 684967 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it really needs a test.