815460 - Always inline JS_THIS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

JS_THIS doesn't always get inlined.  And when it doesn't, at least gcc 4.4 32-bit generates an 8-byte memmove for the jsval copy constructor(!).  Needless to say, this is all very slow.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Always inline JS_THIS so that we don't run into performance issues if the compiler decides not to inline it.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 685417 [details] [diff] [review]
Always inline JS_THIS so that we don't run into performance issues if the compiler decides not to inline it.

Review of attachment 685417 [details] [diff] [review]:
-----------------------------------------------------------------

Swiping.

Comment 3

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/20c8c8762a0c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/20c8c8762a0c