816284 - sort releases on releases.html by submission time

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P3)

Description

[[e-mail] (:bhearsum)]

Newer releases should be at the top. We already sort by pending/running/completed, we should sort by submission time within each of those categories.

Comment 1

[[e-mail] (:bhearsum)]

A few things to do here?
1) Add a submission time Column to the database.
2) Store submission time when accepting a release
3) Adjust the sort here to take it into account: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=a053d88426f5a3c7734994bda15d64bfcfe7b59f;hb=HEAD#l71

Comment 2

[[e-mail] (:bhearsum)]

This is a nice to have -> P3.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Bug 810411 added the submission time data. Just need to sort what we have now.

Comment 4

[[e-mail] (:bhearsum)]

Sorting is done in this method: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=33463012742ba93d8d0a981d650fd744f78595ad;hb=HEAD#l12

It can be adjusted to take submission time into account. Note that submission time should be a secondary sort -- we still want ready/pending above completed.

Massimo, can you take a look at this?

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: replaced sort by name with sort by submission date.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 719950 [details] [diff] [review]
replaced sort by name with sort by submission date.

Landed. The dev environment will pick this up automatically. I'll ask for a push to stage/prod after bug 843228 is landed, so we can batch them together.

Comment 7

[[e-mail] (:bhearsum)]

This is in production now.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

I think this got regressed at some point, or perhaps not carried over to the new datatables layout. Default sort is Name ascending now.

Comment 9

[Massimo Gervasini [:massimo]]

Attachment: added datatable sorting

Added sorting in datatable initialization. Updated datable css so the 'submitted at' column is not highlighted when the table loads.

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 732307 [details] [diff] [review]
added datatable sorting

Review of attachment 732307 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I landed it right into production.