817473 - Do we still need nsNodeSH::PostCreatePrototype?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Seems like Node.prototype should have those properties as needed already with the WebIDL bindings, right?  So I think we can nuke this function...

Comment 1

[Boris Zbarsky [:bzbarsky]]

So first problem:  nsIDOMXULDocument does not inherit from nsIDOMDocument.  Which means that the proto chain for XUL documents doesn't actually go through Node, and they're relying on this method (which they get because they _do_ use nsDocumentSH) to make things work.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Make nsIDOMXULDocument inherit from nsIDOMDocument, so that XUL documents end up with Document.prototype and Node.prototype on their proto chain.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove no-longer-needed nsNodeSH::PostCreatePrototype.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=4b1123f00196

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 687637 [details] [diff] [review]
part 1.  Make nsIDOMXULDocument inherit from nsIDOMDocument, so that XUL documents end up with Document.prototype and Node.prototype on their proto chain.

Review of attachment 687637 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xul/document/src/nsXULDocument.h
@@ +132,5 @@
>      NS_IMETHOD OnPrototypeLoadDone(bool aResumeWalk);
>      bool OnDocumentParserError();
>  
> +    // nsINode interface overrides
> +    virtual nsresult Clone(nsINodeInfo *aNodeInfo, nsINode **aResult) const;

We could keep MOZ_OVERRIDE here?

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 687639 [details] [diff] [review]
part 2.  Remove no-longer-needed nsNodeSH::PostCreatePrototype.

Review of attachment 687639 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, I thought we needed to hook up chrome-only properties but it'll happen automatically because Node is a non-concrete registered new binding interface.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Put back the MOZ_OVERRIDE.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a26a48e9315
https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea9ab04f3c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0a26a48e9315
https://hg.mozilla.org/mozilla-central/rev/21ea9ab04f3c