817520 - (py)make package doesn't package for Metrofox

Status: RESOLVED WORKSFORME

(Firefox for Metro Graveyard :: Build Config, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I was trying to build and package Elm branch today (tip=f0c584f97ade) and after a successful build of current Elm tip, the package command failed:

$ build/pymake/make.py -C objdir/ package
make.py[0]: Entering directory 'c:\Users\Bob\src\elm\objdir/'
make.py[1]: Entering directory 'c:\Users\Bob\src\elm\objdir\browser/installer'
make.py[2]: Entering directory 'c:\Users\Bob\src\elm\objdir\browser\installer'
make.py[2]: Leaving directory 'c:\Users\Bob\src\elm\objdir\browser\installer'
make.py[2]: Entering directory 'c:\Users\Bob\src\elm\objdir\browser\installer'
c:\Users\Bob\src\elm\toolkit\mozapps\installer\packager.mk:763:0$ c:/Users/Bob/src/elm/objdir/_virtualenv/Scripts/python.exe c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -D_MSC_VER=1700 -DJAREXT= -DMOZ_ANGLE_RENDERER=1 -DMOZ_D3DX9_DLL=d3dx9_43.dll -DMOZ_D3DCOMPILER_DLL=D3DCompiler_43.dll -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin --format omni --removals c:/Users/Bob/src/elm/browser/installer/removed-files.in c:/Users/Bob/src/elm/browser/installer/package.manifest ../../dist/bin ../../dist/firefox
Can't remove unpackaged file(s): ../../dist/bin\chrome/reftest.manifest
Can't remove unpackaged file(s): ../../dist/bin\chrome/xslt-qa.manifest
components/xpctest.xpt was not registered
components/xpcomsample.xpt was not registered
Can't remove unpackaged file(s): ../../dist/bin\components/reftest-cmdline.manifest
Can't remove unpackaged file(s): ../../dist/bin\components/nsSample.manifest
Can't remove unpackaged file(s): ../../dist/bin\components/httpd.manifest
res/spacetrace.css was not registered
res/samples was not registered
res/test.properties was not registered
Traceback (most recent call last):
  File "c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py", line 600, in <module>
    main()
  File "c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py", line 586, in main
    packager.finalize()
  File "c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py", line 547, in finalize
    Packager.finalize(self)
  File "c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py", line 305, in finalize
    raise Exception, 'Aborting due to errors'
Exception: Aborting due to errors
c:\Users\Bob\src\elm\toolkit\mozapps\installer\packager.mk:763:0: command 'c:/Users/Bob/src/elm/objdir/_virtualenv/Scripts/python.exe c:/Users/Bob/src/elm/toolkit/mozapps/installer/packager.py -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -D_MSC_VER=1700 -DJAREXT= -DMOZ_ANGLE_RENDERER=1 -DMOZ_D3DX9_DLL=d3dx9_43.dll -DMOZ_D3DCOMPILER_DLL=D3DCompiler_43.dll -DMOZ_CHILD_PROCESS_NAME=plugin-container.exe -DMOZ_SHARED_MOZGLUE=1 -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX= -DDLL_SUFFIX=.dll -DBIN_SUFFIX=.exe -DBINPATH=bin --format omni --removals c:/Users/Bob/src/elm/browser/installer/removed-files.in c:/Users/Bob/src/elm/browser/installer/package.manifest ../../dist/bin ../../dist/firefox' failed, return code 1
c:\Users\Bob\src\elm\config\rules.mk:556:0: command 'c:/mozilla-build/python/python.exe c:/Users/Bob/src/elm/build/pymake/pymake/../make.py libs' failed, return code 2
c:\Users\Bob\src\elm\browser\build.mk:47:0: command 'c:/mozilla-build/python/python.exe c:/Users/Bob/src/elm/build/pymake/pymake/../make.py -C browser/installer' failed, return code 2

That command works on central, it'd be really handy if it worked on Elm/metrofox; I'm trying to put together a demo of H.264 video playback in Metrofox, and it'd be handy if the package command worked.

Comment 1

[Jim Mathies [:jimm]]

I'm guessing this is fixed with the new packager.

Comment 2

[Mike Hommey [:glandium]]

This may or may not be fixed with the newest iterations. Please test again.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

I tested again, and the "package" make command now works on the elm branch with pymake. Thanks!