Closed
Bug 817927
Opened 12 years ago
Closed 11 years ago
[Contacts] Even if Facebook is disabled, you can still click facebook switch
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)
Tracking
(blocking-basecamp:-, b2g18+ fixed)
People
(Reporter: alberto.pastor, Assigned: basiclines)
References
Details
Attachments
(1 file)
|
252 bytes,
text/html
|
jmcf
:
review+
arcturus
:
approval-gaia-v1+
|
Details |
STR: 1.- Open contacts app (without internet connection) 2.- Click Settings button 3.- Click the disabled facebook switch Expected: Nothing happens Actual: The switch receives the click and change its status.
|
Reporter | |
Updated•12 years ago
|
blocking-basecamp: --- → ?
|
||
Comment 1•12 years ago
|
||
well spotted Alberto.
|
|
||
Comment 2•12 years ago
|
||
I have been investigating a bit and it seems the switch BB does not support a disabled mode, thus the transition is triggered always. Assigning to Ismael and Arnau in order to extend the BB to support a disabled state
Assignee: nobody → igonzaleznicolas
Status: NEW → ASSIGNED
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
Priority: -- → P3
|
||
Comment 3•12 years ago
|
||
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
|
|
||
Comment 5•12 years ago
|
||
We won't block on this, but we would take a low risk uplift. Unblocking, but tracking for the branch.
blocking-basecamp: + → -
tracking-b2g18:
--- → +
|
Assignee | |
Comment 6•11 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #699678 -
Flags: review?(jmcf)
Attachment #699678 -
Flags: approval-gaia-master?(francisco.jordano)
|
|
||
Updated•11 years ago
|
Attachment #699678 -
Flags: review?(jmcf) → review+
|
||
Comment 7•11 years ago
|
||
Comment on attachment 699678 [details]
PR
To me a bb+
We already have the patch, is reviewed, and working for me.
a=me
Thanks guys!
Attachment #699678 -
Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
|
|
||
Comment 8•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/7d6e82223cb60d27232cd2b6b19c99b8c0db3580
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•