Closed
Bug 817989
Opened 12 years ago
Closed 12 years ago
[CONTACTS] Is not possible to save a contact with a very long phone number
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)
VERIFIED
FIXED
blocking-basecamp | + |
People
(Reporter: carlosmartinez, Assigned: gwagner)
References
Details
Attachments
(2 files)
1.06 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
1.11 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
Tested in unagi with 12/04/2012 nightly build: Gecko-0b1ed65 Gaia-23ce635 STR: 1-Open contacts app 2-Create a new contact with name, surname and phone number (e.g. 666666666666666666) 3-Tap in done button Expected result --> New contact is saved with the values filled. Actual result --> Done button is marked as inactive but nothing happens.
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Comment 1•12 years ago
|
||
I/Gecko ( 109): -*- ContactDB component: InternationalFormat: null E/GeckoConsole( 109): [JavaScript Error: "this.internationalFormat is null" {file: "resource://gre/modules/PhoneNumber.jsm" line: 197}] This is what I see in logcat. Gregor can you make sure this does not happens with the embedded version of libPhoneNumber?
blocking-basecamp: ? → +
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → anygregor
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 688288 [details] [diff] [review] patch I still have to test it and I will make sure this gets merged to the github repo for phonenumberJS once it's landed.
Attachment #688288 -
Flags: review?(gal)
Assignee | ||
Comment 4•12 years ago
|
||
Tested it and I can save now the number 666666666666666666.
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #688297 -
Flags: review?(gal)
Comment 6•12 years ago
|
||
Comment on attachment 688288 [details] [diff] [review] patch Update the upstream repo too please. And alignment is off. : under the ? or ? under the first this and : under that ?.
Attachment #688288 -
Flags: review?(gal) → review+
Comment 7•12 years ago
|
||
Comment on attachment 688297 [details] [diff] [review] patch Thanks.
Attachment #688297 -
Flags: review?(gal) → review+
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/21689a2577de https://hg.mozilla.org/integration/mozilla-inbound/rev/5941ffc63b8c
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/21689a2577de https://hg.mozilla.org/mozilla-central/rev/5941ffc63b8c
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/931ccf2e6da8 https://hg.mozilla.org/releases/mozilla-beta/rev/d902c67d2362 https://hg.mozilla.org/releases/mozilla-aurora/rev/e6c8ca7e009e https://hg.mozilla.org/releases/mozilla-aurora/rev/cc2d5a097c01
Comment 12•11 years ago
|
||
Unagi Buid ID:20130103070201 - no repro, verified
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•