818066 - [CALL LOG] Call log is not showing correctly when one phone number is linked to 2 or more contacts

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with 12/04/2012 nightly build Gecko-0b1ed65 Gaia-23ce635

STR:

1-Open contacts app and create two different contacts with the same phone number
2-Go to dialer and place a call to the phone number
3-Place another call to the same phone number

Expected result --> Call log is shown correctly with contact name... or 1,2,3... more

Actual result --> Call log is not shown correctly, see screenshot attached
Attachments

Comment 1

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Contacts crashing with more than one call to a phone number added to more than one contact

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Yes, you are completely right, :carlosmartinez This is due to the way we deal with the case of 1 phone number being assigned to more than 1 contact. Right now we are extracting the 9 first characters of the contact name and adding "of N others" at the end (https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/contacts.js#L56). This is not flexible enough either for rendering the text in the call log or for rendering it in the incoming/outgoing attention screens. I am fixing it ;-)

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Solved once the PR to include the list BB in the Call Log has landed in Gaia: https://bugzilla.mozilla.org/show_bug.cgi?id=818465

Comment 4

[rafael.marquez]

Gecko-cfad7c9
Gaia-6c53dfd