818125 - Add SDK 1.12 to Builder

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

We need to add SDK 1.12 to Builder.

This release will need more testing, we should add to dev ASAP.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I have the rc3 build pushed to my fork of Flightdeck, if we want to test with that for now: https://github.com/KWierso/FlightDeck/tree/add1.12rc3

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Wes Kocher (:KWierso) from comment #1)
> I have the rc3 build pushed to my fork of Flightdeck, if we want to test
> with that for now: https://github.com/KWierso/FlightDeck/tree/add1.12rc3

Not sure if that's feasible, we'd need to commit it to the FD repo and deploy it to their dev box. Would rather just wait for the final tag, then it is just a single pull request.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Okay, here's a pull request for adding the final 1.12 to Builder: https://github.com/mozilla/FlightDeck/pull/176

Comment 4

[Sean McArthur [:seanmonstar]]

merged

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Should just need to run the following command on builder -dev to get it added:

./manage.py add_core_lib addon-sdk-1.12 --useversion=1.12

That's a job for oremj, right?

Comment 6

[Piotr Zalewa [:zalun]]

@kwierso please provide the bug which describes how SDK 1.12 is run. There is quite a lot to do to actually implement 1.12 in FlightDeck