818200 - App Permissions List Looks Wrong.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: We can do better...

1a. Can you please vertically center align icons with icons and vertically left align text strings with text strings. Visually you want to have 2 columns. The icon + text string columns look correct. Ones without an icon look incorrect.

1b. Ideally every row would have an icon, please use the generic gray plate + rocket icon if possible.

2. The icons should have a slight drop shadow since they are 50% the size of the app icons, make it 50% of that specification. As you can see some icons are blending with the background

Comment 1

[Etienne Segonzac (:etienne)]

Note that the homescreen/system/keyboard... are not going to be displayed in that list anymore.

Comment 2

[Andrew Overholt [:overholt]]

Patryk and I were speaking about this and he said that the main issue is the lack of a drop shadow with the icons.  To fix this, please just copy the same style from the homescreen but at 50% intensity.

Comment 3

[[e-mail]]

Attachment: screenshot of drop shadow with the icons

Comment 4

[[e-mail]]

Attachment: polish app permision list by add 50% drop shadow with the icons

Comment 5

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/267215315ceb94e0b83bdd41d90f89243bbff6d7

now permission list really looks much better, thanks

Comment 6

[Jason Smith [:jsmith]]

This needs a rationale for a blocking nom. Based on what I'm what I'm seeing in this bug, this is a VD bug that has no functional impact, which will not block. Feel free to nominate for approval though.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Agreed with Jason, please nominate for uplift as this is a welcome improvement but does not block shipping.

Comment 8

[[e-mail]]

Thanks for clarify, marked for uplift

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Fred Lin [:gasolin] from comment #8)
> Thanks for clarify, marked for uplift

Actually, that's not marking for uplift.  You'll need to get approval-gaia-v1+ to uplift.