Closed Bug 818273 Opened 12 years ago Closed 11 years ago

Approval hook should not reject backout commits that do not contain an a=foo

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Keywords: sheriffing-P1)

Attachments

(1 file)

Drives me nuts when backing out.
Keywords: sheriffing-P1
Whiteboard: [sheriff-want]
Attached patch Patch v1Splinter Review
As much as it would make my life easier to also add the exemption to backouts on a closed tree (I frequently hit the hook there too), I think we shouldn't remove the ability to stop pushes, given say infra bustage etc.
Attachment #693391 - Flags: review?(ted)
Comment on attachment 693391 [details] [diff] [review]
Patch v1

Review of attachment 693391 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like a really broad test (starts with "back" or "revert"), but you're the one that deals with sheriffing on a daily basis, not me.
Attachment #693391 - Flags: review?(ted) → review+
Thank you for the quick review again :-)

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> This seems like a really broad test (starts with "back" or "revert"), but
> you're the one that deals with sheriffing on a daily basis, not me.

Yeah agree, but it's what the tree commit message hook uses (in order to catch {Backout,backed out,back out,...}).

Given that:
* it's rare for a commit message not to start with "bug NNNNNN"
* it's just for the a= check (which frankly is fairly useless anyway)

I doubt we should see any problems from this, so suspect easiest to just land and revisit if there are any issues.
Depends on: 823922
In production.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: