Closed
Bug 818482
Opened 12 years ago
Closed 11 years ago
Panning vertically is very jittery
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-basecamp:-, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18+ fixed)
People
(Reporter: st3fan, Assigned: ajones)
Details
(Keywords: b2g-testdriver, unagi)
Attachments
(1 file, 1 obsolete file)
3.70 KB,
patch
|
roc
:
review+
lsblakk
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
When panning vertically slowly, for example while reading an article, the text seems to rapidly jump up and down. It does not jump up and down a lot. Probably just 1 or 2 pixels. But the effect is bad enough to make me a little seasick :-/ I'm not sure if this is a rendering or gesture issue. It does seem to depend on the zoom level.
Comment 1•12 years ago
|
||
Where do async pan and zoom bugs live? I think this is a dupe.
Component: Gaia::Browser → General
Whiteboard: DUPEME
Comment 2•12 years ago
|
||
Related bug 812517? However, already fixed in the beta build on which Stefan experienced this issue.
Comment 3•12 years ago
|
||
per comment #2
Status: NEW → RESOLVED
blocking-basecamp: ? → -
Closed: 12 years ago
Resolution: --- → WORKSFORME
Comment 4•11 years ago
|
||
I can reproduce this reliably in the browser on a 2012-12-21 07:02:01 build (nightly). I was browsing this site: http://wp.me/p1jETZ-dH on my unagi. Dragging my finger slowly upwards to scroll the page gives the rapid up-and-down motion of the text.
Status: RESOLVED → REOPENED
blocking-basecamp: - → ?
Resolution: WORKSFORME → ---
Updated•11 years ago
|
Assignee: nobody → roc
blocking-basecamp: ? → +
Updated•11 years ago
|
Target Milestone: --- → B2G C3 (12dec-1jan)
(In reply to Lawrence Mandel [:lmandel] from comment #2) > Related bug 812517? However, already fixed in the beta build on which Stefan > experienced this issue. This isn't the "dancing text" symptom; the text snapping stays consistent. Rather, this looks like an offset computation in APZC going wrong.
Assignee: roc → ajones
Comment 6•11 years ago
|
||
Is bug 824702 a dupe of this? (And FWIW I can still reproduce this on a 2012-12-30 build on Unagi)
Comment 7•11 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #6) > Is bug 824702 a dupe of this? While the symptoms are the same, they're not exactly the same so I don't think they're dupes.
Updated•11 years ago
|
Target Milestone: B2G C3 (12dec-1jan) → B2G C4 (2jan on)
Comment 8•11 years ago
|
||
We discussed this again at triage today and while we'd *love* to see a patch for this, we decided we can't block on it.
blocking-basecamp: + → -
tracking-b2g18:
--- → +
Josh, given our out-of-band communication, would you recommend holding the release for this bug?
blocking-basecamp: - → ?
Flags: needinfo?(jcarpenter)
Comment 10•11 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #9) > Josh, given our out-of-band communication, would you recommend holding the > release for this bug? Nope. That specifically pertained to the behaviour seen when two-finger scrolling, and is a nice-to-fix.
Flags: needinfo?(jcarpenter)
Updated•11 years ago
|
blocking-basecamp: ? → -
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 698868 [details] [diff] [review] Fix single pixel jitter on fling This seems to fix the problem but I haven't investigated why this rounding change is necessary.
Attachment #698868 -
Attachment description: Bug 818482 - Fix single pixel jitter on fling; r=cjones → Fix single pixel jitter on fling
Assignee | ||
Updated•11 years ago
|
Attachment #698868 -
Flags: review?(roc)
Comment on attachment 698868 [details] [diff] [review] Fix single pixel jitter on fling Review of attachment 698868 [details] [diff] [review]: ----------------------------------------------------------------- Add a comment that we don't know why truncation is needed here.
Attachment #698868 -
Flags: review?(roc) → review+
Assignee | ||
Comment 14•11 years ago
|
||
Attachment #698868 -
Attachment is obsolete: true
Attachment #701322 -
Flags: review?(roc)
Comment on attachment 701322 [details] [diff] [review] Remove rounding of scroll compensation in AZPC Review of attachment 701322 [details] [diff] [review]: ----------------------------------------------------------------- sweet
Attachment #701322 -
Flags: review?(roc) → review+
Comment 16•11 years ago
|
||
Try run for a5d85dd1a190 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=a5d85dd1a190 Results (out of 28 total builds): success: 26 warnings: 2 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-a5d85dd1a190
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 17•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed67c9f65a6d
Keywords: checkin-needed
Whiteboard: DUPEME
Assignee | ||
Comment 18•11 years ago
|
||
This patch is on top of 811950 so I will rebase it if 811950 doesn't get b2g18 approval.
Comment 19•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ed67c9f65a6d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → FIXED
Comment on attachment 701322 [details] [diff] [review] Remove rounding of scroll compensation in AZPC Very safe patch that improves browser panning. We'd like to take this for another reason too; ping me or Josh for details.
Attachment #701322 -
Flags: approval-mozilla-b2g18?
Updated•11 years ago
|
status-b2g18:
--- → affected
Comment 21•11 years ago
|
||
Comment on attachment 701322 [details] [diff] [review] Remove rounding of scroll compensation in AZPC low risk, high user benefit - approved for landing to branch, please land before 1/25 and mark the status flag as fixed once landed.
Attachment #701322 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Comment 22•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/64bfbdb96823
You need to log in
before you can comment on or make changes to this bug.
Description
•