818660 - Un-prefix gradients from about:home page contents

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Soumya Deb [:Debloper]]

The -moz prefixes are no longer required with CSS linear-gradients for Firefox 16+, so it's safe to remove the prefixes and use the standard syntax for the landing about:home page.

Comment 1

[Soumya Deb [:Debloper]]

Attachment: Patch file

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 688931 [details] [diff] [review]
Patch file

> body[narrow] #restorePreviousSessionSeparator {
>   margin: 0 auto;
>   width: 512px;
>   height: 3px;
>-  background-image: -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>-                    -moz-linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>-                    -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));
>+  background-image: linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>+                    linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>+                    linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));

This is invalid syntax for linear-gradient. I believe linear-gradient(to right, ...) is what you want here.

Comment 3

[Soumya Deb [:Debloper]]

Attachment: Patch file

Yep, yep - my bad!
Updated. :)

P.S: Does it require explicit ui-review?
Which other approvals (aurora/beta etc.) should I ask for it?

Comment 4

[Masatoshi Kimura [:emk]]

Do you have any idea simulating Aero-style light beams using the new syntax?

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 689265 [details] [diff] [review]
Patch file

Thanks!

Comment 6

[Dão Gottwald [:dao]]

(In reply to Soumya Deb [:Debloper] from comment #3)
> P.S: Does it require explicit ui-review?

nope

> Which other approvals (aurora/beta etc.) should I ask for it?

None. This only needs to land on mozilla-central.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cfe42934c8f

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2cfe42934c8f