818881 - Wait time report in Build API uses incorrect explanation text

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Frank Wein [:mcsmurf]]

The wait time report at https://secure.pub.build.mozilla.org/buildapi/reports/waittimes says:
"The number on the Number column is how many minutes a build waited to start, rounded down."
This should probably say:
"The number on the "Wait Time" column is how many minutes a build waited to start, rounded down. The number on the "Number" column is how many builds started within a particular time period."

Comment 1

[Justin Wood (:Callek)]

Its been a long long time since I looked at that page for the wait times (I use the auto-e-mail which is generated from a different template), nor do *I* know how to update the code for that page.

However i found https://mxr.mozilla.org/build/source/buildapi/buildapi/templates/reports/waittimes.mako#102 which I can happily say, "patches accepted" the repo is hg.m.o/build/buildapi

Comment 2

[kartik gupta]

Attachment: patch1.diff

This is a patch i have written to fix the bug, i didnt know whom to set for the feedback so i am leaving it blank for now.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8566483 [details] [diff] [review]
patch1.diff

Thanks for writing the patch, which is on the right track and I'll grant f+ (feedback). Lets fix up the English properly while we're here, so please create another patch for me to review.

I'd suggest something like this:
 The <b>Wait Time</b> is the number of minutes a build waited to start, rounded down.
and not worry about Number, that's self-explanatory I think.

Could you also replace 'lister' with 'listed'.

Comment 4

[kartik gupta]

Attachment: patch2.diff

The corrections have been made.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8567603 [details] [diff] [review]
patch2.diff

Looks good, r+. I've landed it at
  https://hg.mozilla.org/build/buildapi/rev/843f83c7f280
with a version bump added for deployment.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Deployed using https://wiki.mozilla.org/ReleaseEngineering/How_To/Update_BuildAPI. Thanks for the patch.

Comment 7

[kartik gupta]

Nick, can you put my name as the asignee, as i cant see this bug on my profile.