819244 - [Clock] The alarm attention screen uses 24H format but the time picker uses 12H format, which is not consistent.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[zhang.yonglin]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120420145725

Steps to reproduce:

1、set an alarm in 12 hours.
2、the alarm is start on time.


Actual results:

the format of the time is in 24 hours, not in the 12 hours


Expected results:

the format of the time is in 12 hours.

Comment 1

[Gene Lian (I already quit Mozilla)]

Thanks for firing this but I have difficulties parsing the description. Do you mean:

  1. Supposing it's 11:00am now.
  2. Wanting to set an alarm at 12:00am.
  3. It shows it's going to fire after 12 HOURS 59 MINUTES instead of 59 MINUTES.

If yes, then the behaviour is expected, because 12:00pm usually refer to the *noon* and 12:00am refer to the *midnight*. Please see Bug 796451.

Comment 2

[zhang.yonglin]

(In reply to Gene Lian [:gene] from comment #1)
> Thanks for firing this but I have difficulties parsing the description. Do
> you mean:
> 
>   1. Supposing it's 11:00am now.
>   2. Wanting to set an alarm at 12:00am.
>   3. It shows it's going to fire after 12 HOURS 59 MINUTES instead of 59
> MINUTES.
> 
> If yes, then the behaviour is expected, because 12:00pm usually refer to the
> *noon* and 12:00am refer to the *midnight*. Please see Bug 796451.

so sorry, you misunderstand what i mean, i mean that the time format is inconsistent, when i set the alarm ,the time is 12-hour format, but when the alarm is on , it's in 24-hour format.

Comment 3

[Gene Lian (I already quit Mozilla)]

Thanks Yonglin! It seems just a UX issue. Sorry for my misunderstanding!

Ivan, is that a UI bug or a UX bug?

Comment 4

[John Shih]

I think this a bug and is also easy to fix
ping Ian

Comment 5

[[e-mail], [e-mail]]

I see the console warn as following:
E/GeckoConsole(  585): Content JS WARN at app://clock.gaiamobile.org/shared/js/l10n.js:52 in consoleWarn: [l10n] #dateTimeFormat_%X is undefined.
We need to listen 'localized' event to prevent the warn.

Comment 6

[[e-mail], [e-mail]]

Since the pr(https://github.com/mozilla-b2g/gaia/pull/7191) is merge, we can close the issue now.
Fixed Bug 823431 and this issue.

Comment 7

[John Shih]

verified on unagi
build info
12/27
gaia master: a698a8b4018d5e98008ae4ca91bf0ad49c5591ad
b2g-18: 2008afe879e6

Comment 8

[Misty Byrd]

This issue repros in B2G: Gaia, OS version 1.0.0, Build ID: 20121217070202
Test Case: 1789

Will verify in new build for second test pass

Comment 9

[Misty Byrd]

This issue is fixed  in Ungia, build 20130104070203 v.1.0