819291 - crash in nsIContent::GetPrimaryFrame, called from mozilla::a11y::TextAttrsMgr::GetAttributes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

This bug was filed from the Socorro interface and is 
report bp-1a663c9b-4797-43a3-9c0c-961c82121207 .
============================================================= 

I encountered this crash once today when starting a new article on my WordPress blog, but it doesn't happen reliably. Filing it just in case it reveals something obvious. Might also be related to problems Trevor is encountering with enhancing text attribute tests.

Comment 1

[Trevor Saunders (:tbsaunde)]

It seems somehow we have a HyperTextAccessible for something that isn't a element, Alex any idea how that's possible?  How do you eel about an assert that doesn't happen?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> It seems somehow we have a HyperTextAccessible for something that isn't a
> element, Alex any idea how that's possible?  How do you eel about an assert
> that doesn't happen?

I don't see alternatives.

Comment 3

[Trevor Saunders (:tbsaunde)]

Marco could you try and reproduce with this build? https://tbpl.mozilla.org/?tree=Try&rev=22a25d1c1879

Comment 4

[Marco Zehe (:MarcoZ)]

Trevor, I never saw the bug again unfortunately. So reproducing it may become a real challenge. :)

Comment 5

[Marco Zehe (:MarcoZ)]

A community remember just reported on Twitter that (s)he was seeing crashes, and when I received report IDs, found that this is the same bug I was seeing. The IDs are:
bp-d422654c-bf81-47e7-a9f3-887ca2130326
bp-05bd58fe-2a34-4a2e-a2b8-ec9842130326

Comment 7

[vikram]

I am not able to reproduce this bug in latest build, please send me scenario in which case this bug is produceable. and also let me steps to reproduce this bug.

Comment 8

[Marco Zehe (:MarcoZ)]

Had another of those  crashes after ages. I was answering a Facebook friend request, and the dialog where I was asked whether I wanted to confirm or delete had just gone away after I clicked Confirm.
https://crash-stats.mozilla.com/report/index/7e47c858-ee5c-4b25-a15a-a34922140128

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Is this bug still taken? If not, I am willing to take it on.
Thanks.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Taking since did not get a response.

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 819291 patch

Added an assertion and the handler for null.

Comment 12

[alexander :surkov (:asurkov)]

Comment on attachment 8375822 [details] [diff] [review]
819291 patch

Review of attachment 8375822 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55066842727a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/55066842727a