Closed
Bug 819304
Opened 12 years ago
Closed 9 years ago
[Utility tray] "Clear all" button should have a hit state
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pabloUX, Assigned: durwasa.chakraborty, Mentored)
Details
(Whiteboard: interaction)
Attachments
(4 files, 3 obsolete files)
In order to give feedback to the user, specially when any notification is non-erasable (update avalaible, e.g.), is important to show a hit state when the button is tapped. If not, the user could be confused and think its mobile doesn't work fine.
Reporter | ||
Updated•12 years ago
|
Whiteboard: visual design
Updated•9 years ago
|
Mentor: etienne
Comment 1•9 years ago
|
||
Attachment #8575935 -
Flags: review?(etienne)
Comment 2•9 years ago
|
||
Updated•9 years ago
|
Attachment #8575935 -
Attachment is patch: false
Updated•9 years ago
|
Attachment #8575937 -
Attachment is patch: false
Attachment #8575937 -
Attachment mime type: text/plain → video/mp4
Updated•9 years ago
|
Attachment #8575935 -
Flags: review?(etienne)
Comment 3•9 years ago
|
||
Updated•9 years ago
|
Attachment #8575937 -
Flags: ui-review?(epang)
Comment 4•9 years ago
|
||
Comment on attachment 8575952 [details] [review] [gaia] giniouxe:Bug#819304 > mozilla-b2g:master All good, just waiting for the ui-review before landing. (<3 the orange but Eric will know for sure what was spec'ed)
Attachment #8575952 -
Flags: review+
Comment 5•9 years ago
|
||
Thanks for the feed back !
Comment 6•9 years ago
|
||
(In reply to aurelie.ginioux from comment #5) > Thanks for the feed back ! Great that we're adding a hit state! We don't have a colour defined, why don't we try out 50% opacity of the current unpressed state. Thanks!
Flags: needinfo?(aurelie.burnier)
Comment 7•9 years ago
|
||
Sorry, ni'ed the wrong person
Flags: needinfo?(aurelie.burnier) → needinfo?(aurelie.ginioux)
Comment 8•9 years ago
|
||
(In reply to Eric Pang [:epang] from comment #6) > (In reply to aurelie.ginioux from comment #5) > > Thanks for the feed back ! > > Great that we're adding a hit state! We don't have a colour defined, why > don't we try out 50% opacity of the current unpressed state. Thanks! OK, I'm updating the PR.
Flags: needinfo?(aurelie.ginioux)
Comment 9•9 years ago
|
||
Attachment #8575937 -
Attachment is obsolete: true
Attachment #8575937 -
Flags: ui-review?(epang)
Attachment #8576075 -
Flags: review?(etienne)
Updated•9 years ago
|
Attachment #8575952 -
Attachment is obsolete: true
Comment 10•9 years ago
|
||
Comment on attachment 8576075 [details] [diff] [review] Hit state : add 50% opacity to button on hit Hey Eric, since we switch the text-color to gray once the "Clear all" button is pressed (because it's disabled when there's no notification) it's indeed really hard to see the hit state. Could we add a background-color on the button instead?
Flags: needinfo?(epang)
Attachment #8576075 -
Flags: review?(etienne)
Comment 11•9 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #10) > Comment on attachment 8576075 [details] [diff] [review] > Hit state : add 50% opacity to button on hit > > Hey Eric, since we switch the text-color to gray once the "Clear all" button > is pressed (because it's disabled when there's no notification) it's indeed > really hard to see the hit state. > > Could we add a background-color on the button instead? sure, let's try #00caf2 at 20% opacity and see how that looks. Thanks!
Flags: needinfo?(epang)
Comment 12•9 years ago
|
||
> > Could we add a background-color on the button instead?
>
> sure, let's try #00caf2 at 20% opacity and see how that looks. Thanks!
Note: we'll probably need to remove the border-radius that's added by default to buttons too.
Flags: needinfo?(aurelie.ginioux)
Comment 13•9 years ago
|
||
Hi, I applied the changes, but it seems I have no way to test it : the WebIDE simulator doesn't seem to work (can't visualize CSS changes, tried with an ugly pink to be sure), and I have no Firefox OS phone... Any idea ? Thanks !
Flags: needinfo?(aurelie.ginioux)
Updated•9 years ago
|
Assignee: nobody → durwasa.chakraborty
Comment 14•9 years ago
|
||
Comment 15•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8666907 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 16•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master I made some comments on github, let me know if anything's unclear.
Attachment #8667177 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 17•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master Commented on github, I think there was a little misunderstanding :)
Attachment #8667177 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 18•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master Looks like we'll need one (hopefully)last round. Comments on github. Think about is as practice for your git skills :)
Attachment #8667177 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 19•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master Detailed comments on github :)
Attachment #8667177 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 20•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master Clearing while waiting for the PR to be updated :)
Attachment #8667177 -
Flags: review?(etienne)
Assignee | ||
Updated•9 years ago
|
Attachment #8667177 -
Flags: review?(etienne)
Comment 21•9 years ago
|
||
Comment on attachment 8667177 [details] [review] [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master Here we go :) Ready for the next bug!
Attachment #8667177 -
Flags: review?(etienne) → review+
Comment 22•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/cc7e572ec93dd8d6afd403687e13e3874ada0223
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 23•9 years ago
|
||
(In reply to Etienne Segonzac (:etienne) from comment #21) > Comment on attachment 8667177 [details] [review] > [gaia] durwasa-chakraborty:bug-hit-state > mozilla-b2g:master > > Here we go :) > Ready for the next bug! Yes sir absolutely ready :) :) Hoping that it won't be a nightmare for you ... :) :) My deepest apologies again
Comment 24•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•