819323 - Figure out if getPayload should call getCounters

Status: RESOLVED INVALID

(Toolkit :: Telemetry, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

From bug 818549:

It also looks like we might have a bug in the getPayload() method.. it never calls getCounters() !

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It is not clear we should call it. It is used to set this._startupIO.startupSessionRestoreReadBytes and this._startupIO.startupSessionRestoreWriteBytes in the sessionstore-windows-restored message.

Simply calling gatherStartup instead of gatherStartupInformation in getPayload will produce a more current (inaccurate) value for those member variables no?

Or is your intention to call  getCounters() and store it in new member variables (say ReadsSoFar and WritesSoFar)?

Comment 2

[Vladan Djeric (:vladan)]

(In reply to Rafael Ávila de Espíndola (:espindola) from comment #1)
> It is not clear we should call it. It is used to set
> this._startupIO.startupSessionRestoreReadBytes and
> this._startupIO.startupSessionRestoreWriteBytes in the
> sessionstore-windows-restored message.
> 
> Simply calling gatherStartup instead of gatherStartupInformation in
> getPayload will produce a more current (inaccurate) value for those member
> variables no?

Right