819330 - Bugzilla crashes when cloning a bug if the CC list is empty

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jolum]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232

Steps to reproduce:

Attempted to clone an existing bug where the logged in user was not the reporter.


Actual results:

Bugzilla reported the following: 
Software error:
Can't use an undefined value as an ARRAY reference at /var/www/bugzilla/enter_bug.cgi line 217.



Expected results:

In  BZ v4.5 the code at line 217 reads: 
if ($cloned_bug->reporter->id != $user->id) 
        && none { $_ eq $cloned_bug->reporter->login } @{$cloned_bug->cc}) {
        $vars->{'cc'} = join (", ", $cloned_bug->reporter->login, $vars->{'cc'}); 
    }

In our previous version (3.4) it use to read:
if ($cloned_bug->reporter->id != $user->id) {       
        $vars->{'cc'} = join (", ", $cloned_bug->reporter->login, $vars->{'cc'}); 
    }

Comment 1

[Frédéric Buclin]

Confirmed. This happens only if there is nobody in the CC list of the original bug. This is a regression due to bug 715432.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

The right fix is to make $bug->cc always return an arrayref. It doesn't make sense to return undef when the CC list is empty. Else this always force the callers to do something like @{$bug->cc || []} which is ridiculous.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 689728 [details] [diff] [review]
patch, v1

Review of attachment 689728 [details] [diff] [review]:
-----------------------------------------------------------------

Works as expected. r=dkl

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified enter_bug.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 8520.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified enter_bug.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 8485.