819613 - Firefox for Metro should support mouse gestures/buttons for back/forward

Status: RESOLVED FIXED

(Core Graveyard :: Widget: WinRT, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I have the Microsoft Touch mouse, which includes a touch gesture for going back/forward in a browser's history (or in other programs where it makes sense) by swiping my thumb either down or up against the side of the mouse. This works in desktop Firefox and IE, as well as Metro IE. 

It doesn't seem to do anything in Metro Firefox. I think it should, at least for parity with IE.

The MozillaZine thread linked in this bug's URL field says that the hardware back/forward buttons on Logitech mice also don't work in Metro Firefox, while it does work everywhere else. I'd guess it's the same issue for both the gestures and the buttons?

Comment 1

[Jim Mathies [:jimm]]

not blocking but wanted as soon as we have the time.

Comment 2

[Marco Mucci [:MarcoM]]

Removing 'ux' keyword as UX dependency bug has been created which blocks bug 819613.

Comment 3

[Jim Mathies [:jimm]]

We need to add support for application command messages - 

http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#5091
http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#3698

Comment 4

[Jim Mathies [:jimm]]

Attachment: widget patch v.1

I have to find a keyboard i can test this with.

Comment 5

[Jim Mathies [:jimm]]

This is working in widget, but we also need front end support - 

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1471

Comment 6

[Marco Mucci [:MarcoM]]

Hey Jim, can you provide a point value.

Comment 7

[Jim Mathies [:jimm]]

Attachment: browser patch v.1

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8370395 [details] [diff] [review]
browser patch v.1

Review of attachment 8370395 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure how to test? Code-wise looks fine though

::: browser/metro/base/content/browser-ui.js
@@ +1145,5 @@
>      }
>    },
>  
> +  handleAppCommandEvent: function (aEvent) {
> +    switch (aEvent.command) {

Nit: I would normally indent the switch block?

Comment 9

[Jim Mathies [:jimm]]

(In reply to Sam Foster [:sfoster] from comment #8)
> Comment on attachment 8370395 [details] [diff] [review]
> browser patch v.1
> 
> Review of attachment 8370395 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not sure how to test? Code-wise looks fine though
> 
> ::: browser/metro/base/content/browser-ui.js
> @@ +1145,5 @@
> >      }
> >    },
> >  
> > +  handleAppCommandEvent: function (aEvent) {
> > +    switch (aEvent.command) {
> 
> Nit: I would normally indent the switch block?

I was not able to test much either aside from Back/Forward. The widget code comes from win32 widget though which we now share, and the front end code is pulled from desktop's browser.js, so we should be ok.

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8370375 [details] [diff] [review]
widget patch v.1

Review of attachment 8370375 [details] [diff] [review]:
-----------------------------------------------------------------

Seems pretty straightforward and it sounds like you tested with the 'back' and 'forward' keys

Comment 11

[Jim Mathies [:jimm]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/82937be94f94
remote:   https://hg.mozilla.org/integration/fx-team/rev/dde12ccefb19

thanks guys.

Comment 12

[Jim Mathies [:jimm]]

backed out due to strange link bustage - 

remote:   https://hg.mozilla.org/integration/fx-team/rev/25572e0fbf0b
remote:   https://hg.mozilla.org/integration/fx-team/rev/07a8c548e37c
remote:   https://hg.mozilla.org/integration/fx-team/rev/7260560686bb

Comment 13

[Jim Mathies [:jimm]]

Odd, never run into this before, B2G Desktop Windows Opt failed to link due to missing nsGkAtoms in nsWindowBase. Windows builds were fine.

Comment 14

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #13)
> Odd, never run into this before, B2G Desktop Windows Opt failed to link due
> to missing nsGkAtoms in nsWindowBase. Windows builds were fine.

B2G Desktop Windows Op isn't a unified build.

Comment 15

[Jim Mathies [:jimm]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/d0e1eff20097
remote:   https://hg.mozilla.org/integration/fx-team/rev/5fd318a789f6

Pushed again with a missing include and a try run.

https://tbpl.mozilla.org/?tree=Try&showall=0&rev=4aa9227c1c22

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0e1eff20097
https://hg.mozilla.org/mozilla-central/rev/5fd318a789f6

Comment 17

[Marco Mucci [:MarcoM]]

For testing and verification.  Reopen if any defects found.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Setting needinfo on myself to try to verify this once I track down the dongle for my mouse.

Comment 19

[Kamil Jozwiak [:kjozwiak]]

We've also ordered the mouse to the TO office so will have it for any future test cases. If it comes in before Wes can find his dongle, I'll complete verification.

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, I've looked in all of the places where the dongle could possibly be and I don't see it. Guess this is up to the TO office to verify, now. :(

Comment 21

[Kamil Jozwiak [:kjozwiak]]

no worries Wes, I ordered a mouse and it shipped today.. Hopefully it arrives tomorrow or by Monday - Tuesday. Thanks for checking!

Comment 22

[Kamil Jozwiak [:kjozwiak]]

Clearing the "needinfo" as the metrofx project has been cancelled. Unfortunately the mouse came in after the project was cancelled :(