819825 - some ICE/STUN negotiations hang or crash on Android in mbslen()

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: WIP patch 1: abort the function rather than trying to handle a null return from setlocale()

After apply the build patches for Android in the dependency tree for bug 750869, the ICE unittest hangs or crashes in mbslen.  The problem is that setlocale() on Android returns null.

The calling code actually isn't really caring about this function, excitingly.  Here's a patch that makes things run further, but it would be good to verify that's impossible/hard to get UTF8 before we just punt.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: version2: null-check set-locale, and abort the function if that fails

This strikes me as somewhat more maintainable/readable code than adding another ifdef clause.  And it makes the ice unit tests pass.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 691901 [details] [diff] [review]
version2: null-check set-locale, and abort the function if that fails

r=abr over IRC

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Try server build:

https://tbpl.mozilla.org/?tree=Try&rev=6b62c415dd7f

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Pushed to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a891c0a6e7

in-testsuite+, as this was caught by ice_unittest, and this fix makes that test pass.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b9a891c0a6e7