820026 - If a device contact without name and last name is linked to a FB friend, those fields appear as empty in Contacts App

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Marcelino Veiga Tuimil [:sonmarce]]

*Procedure
1-Create a contact only with phone number filled
2-Link the concat to a FB contact with name and surname filled.

*Expected Result
The contact is linked and shows the name and surname of FB contact

*Actual Result
The fields name and surname are showing empty in contact details

Comment 1

[Jose Manuel Cantera]

I'm gonna implement this bug as follows:

If the deviceContact has givenName and familyName, it will be take precedence over the FB Name.

If givenName or familyName are empty, then the FB correspondence will be taken i.e. if the givenName is given but not the familyName the final name will be device(givenName), facebook(familyName) and viceversa. if none of them are device-defined then the FB Name will appear. 

Please take into account that FB names will be subject to local changes made by the user. 

Please confirm that you agree with this approach

thanks!

Comment 2

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 6985

Comment 3

[Jose Manuel Cantera]

Comment on attachment 691547 [details]
Pointer to GH PR 6985

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: UX will be bad and a nice FB feature will lost 

Testing completed: 
Risk to taking this patch (and alternatives if risky):

Master can judge himself but the risk is low

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 691547 [details]
Pointer to GH PR 6985

Changing affecting to fb enabled.

JS check looking good, also got the r+, plus needed late mini feature.

Comment 5

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/f3fd1b91aefdb0fef43734818c9cbb3186e9deb8

Comment 6

[isabelrios]

2012/28/01 build. Gecko-cfad7c9 Gaia-6c53dfd