Closed
Bug 820117
Opened 12 years ago
Closed 12 years ago
XQuartz verification no longer required in python/mozboot/mozboot/osx.py
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: jlmendezbonini, Assigned: jlmendezbonini)
Details
Attachments
(1 file, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Steps to reproduce: System: OSX 10.8.2 and using homebrew I ran the one-line Firefox build prerequisites bootstrap command: wget https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py && python bootstrap.py Actual results: Received this message: "Homebrew needs XQuartz installed in order to build some dependencies. Please download and install XQuartz from the following URL: http://xquartz.macosforge.org/downloads/SL/XQuartz-2.7.3.dmg\ When that has finished, please relaunch bootstrap." Expected results: Homebrew no longer requires XQuartz to build Python. See https://github.com/mxcl/homebrew/issues/14989 for the discussion and https://github.com/mxcl/homebrew/commit/8f0c5f795816690e903b1e74b343f2572dda45ff for the commit that removes the dependency.
Assignee | ||
Comment 1•12 years ago
|
||
My first bug report so I'm not sure whether the submitted patch file was generated properly. Thanks.
Assignee | ||
Updated•12 years ago
|
Attachment #690537 -
Attachment description: Removed XQuartz verifications from python/mozboot/bin/osx.py → Removed XQuartz verifications from python/mozboot/mozboot/bin/osx.py
Assignee | ||
Updated•12 years ago
|
Summary: XQuartz verification no longer required in python/mozboot/bin/osx.py → XQuartz verification no longer required in python/mozboot/mozboot/osx.py
Assignee | ||
Updated•12 years ago
|
Attachment #690537 -
Attachment description: Removed XQuartz verifications from python/mozboot/mozboot/bin/osx.py → Removed XQuartz verifications from python/mozboot/mozboot/osx.py
Assignee | ||
Updated•12 years ago
|
Attachment #690537 -
Flags: review?(gps)
Comment 2•12 years ago
|
||
Comment on attachment 690537 [details] [diff] [review] Removed XQuartz verifications from python/mozboot/mozboot/osx.py Review of attachment 690537 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! The patch is /almost/ proper. We'd like patches to have the header lines (author, commit message, etc) to make it easier to check things in. See https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F (preferred) or |git format-patch|. But, this being your first patch, I can normalize things for you. Your name and email will be attached to the patch. Is it OK if I use Jorge Luis Mendez <jlmendezbonini@gmail.com>?
Attachment #690537 -
Flags: review?(gps) → review+
Comment 3•12 years ago
|
||
Please answer authorship question from previous comment or upload a properly-formatted patch. Then, I'll check this in for you.
Assignee: nobody → jlmendezbonini
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(jlmendezbonini)
Assignee | ||
Comment 4•12 years ago
|
||
Generated with: git format-patch -U8 -W. Hopefully this is good. If not, please go ahead and fix it for me if it's not too much trouble. I don't want to make you waste too much time with such a simple patch. Thanks.
Attachment #690537 -
Attachment is obsolete: true
Flags: needinfo?(jlmendezbonini)
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ce1a8ae8ed6 This should be merged into the main tree within a few hours. Congratulations on landing your first patch!
Target Milestone: --- → mozilla20
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7ce1a8ae8ed6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•