821101 - Contacts: Fix phonenumberJS error

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 691582 [details] [diff] [review]
patch

Review of attachment 691582 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/fallback/ContactDB.jsm
@@ +270,5 @@
>                    debug("InternationalFormat: " + parsedNumber.internationalFormat);
>                    debug("InternationalNumber: " + parsedNumber.internationalNumber);
>                    debug("NationalNumber: " + parsedNumber.nationalNumber);
>                    debug("NationalFormat: " + parsedNumber.nationalFormat);
> +                  if (parsedNumber.internationalNumber && number.toString() !== parsedNumber.internationalNumber) {

Nit: I'd split this to two lines ;)

Comment 2

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbff6dc7b50

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4dbff6dc7b50

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 691582 [details] [diff] [review]
patch

[Triage Comment]

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Not blocking on this since no motivation was given why this bug is important. Feel free to renom with a motivation, or just uplift the patch since I just a+'ed it.

Comment 7

[Gregor Wagner [:gwagner]]

It can cause an Error in our ContactsDB code during importing or saving contacts and we never return from the request.
So it's impossible to save a contact or import contacts from the SIM card. 
Already seen in bug 820843.

E/GeckoConsole(  674): [JavaScript Error: "(intermediate value).internationalNumber is null" {file: "resource://gre/modules/ContactDB.jsm" line: 275}]

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39fc83f65037
https://hg.mozilla.org/releases/mozilla-b2g18/rev/eda5f62ab373