821388 - [Email. UX VD] Icons for reply, reply all and forward look a bit weak in comparison with the rest of icons and not legible enough.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P3)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Shows the screen where the mentioned icons live

Arrow icons can use some tweaking to look more solid and read better. They have less weight then the rest of the set, feels a bit off system.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 2

[Peter La]

Attachment: Patch

https://github.com/mozilla-b2g/gaia/pull/8918

Comment 3

[Sam Joch [:samjoch]]

Comment on attachment 732012 [details]
Patch

Only icons r+

Comment 4

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/746b3fe9753f12de9a56a47b7de6502387ca3087

Comment 5

[Sam Joch [:samjoch]]

Comment on attachment 732012 [details]
Patch

Master commit is https://github.com/mozilla-b2g/gaia/commit/746b3fe9753f12de9a56a47b7de6502387ca3087

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: -
Testing completed: -
Risk to taking this patch (and alternatives if risky): low risk only assets
String or UUID changes made by this patch: -

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 732012 [details]
Patch

Icons only changes. Sounds safe to me to land everywhere.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"

I think these icons are better!  Please uplift.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 746b3fe9753f12de9a56a47b7de6502387ca3087
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 9

[James Lal [:lightsofapollo]]

We can't do more here without conflicts resolved. Please supply a patch or uplift directly.

Comment 10

[Peter La]

I think I'm going to need Sam's help here.

Sam, can you investigate/fix this conflict?  I have no idea how.

Comment 11

[Peter La]

I accidentally cleared naoki's needsinfo flag for Alex Keybl.  Adding it back.  Please see Naoki's last comment above.

Sorry about that.

Comment 12

[Sam Joch [:samjoch]]

Uplifted in v1-train: https://github.com/mozilla-b2g/gaia/commit/2d7766d6781523db627fb56726872210d68840a4