821594 - sutAgent: null return for isdir on non-rooted device with su

Status: RESOLVED WONTFIX

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

I tried running the new remotecppunittests on a device that does not provide a default root shell, but allows su (my Galaxy Tab, fwiw). The test failed with:

  File "/home/mozdev/src/config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "/home/mozdev/src/config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "/home/mozdev/src/testing/remotecppunittests.py", line 180, in <module>
    tester = RemoteCPPUnitTests(dm, options, progs)
  File "/home/mozdev/src/testing/remotecppunittests.py", line 26, in __init__
    self.setupBin(progs)
  File "/home/mozdev/src/testing/remotecppunittests.py", line 34, in setupBin
    if not self.device.dirExists(self.remoteTestRoot):
  File "/home/mozdev/src/testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py", line 394, in dirExists
    raise DMError('Automation Error: DeviceManager isdir returned null')
mozdevice.devicemanager.DMError: Automation Error: DeviceManager isdir returned null

sutAgent was exec'ing:

su 
-c
LD_LIBRARY_PATH=/vendor/lib:/system/lib ls -l /data/local/tests/cppunittests

waiting for 5 s for a response, and timing out.

Consider:

$ adb shell
shell@android:/ $ su -c "ls -l /data/local/tests/cppunittests"
<<immediate response>>
/data/local/tests/cppunittests: No such file or directory
shell@android:/ $ run-as com.mozilla.SUTAgentAndroid
com.mozilla.SUTAgentAndroid@android:/ $ su -c "ls -l /data/local/tests/cppunittests"
<<approx 10 s pause here>>
Permission denied


I cannot think of any change we should make to avoid the Permission denied failure, but we could provide better failure messages. We can consider:
 - increasing the timeouts for commands that (can) use su
 - providing "command timed out" return messages when a command times out


(None of this nonsense happens on a tegra, so this bug only affects a small, exclusive club of people who sometimes try to run sutAgent in inhospitable environments.)

Comment 1

[Geoff Brown [:gbrown]]

adb works well just about everywhere now...not much point to this bug now.