Closed Bug 821875 Opened 11 years ago Closed 10 years ago

Day w/ No Events Looks Awkwards

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: davidwalsh, Unassigned)

Details

Attachments

(1 file)

Days with no events on a calendar's given day simply show a header that says something like:

"FRIDAY DECEMBER 2012"

Under that text, instead of an empty space, something like this should be provided:

"There are no events on this day. <a href=''>Create one</a>."
Attached patch Proposed patchSplinter Review
Hello James,

Here is the point to new pull request : https://github.com/mozilla-b2g/gaia/pull/10950

Please help me by reviewing this patch :)

Regards,
Attachment #774986 - Flags: review?(jlal)
Comment on attachment 774986 [details] [diff] [review]
Proposed patch

The code I see looks good but you need tests covering these changes... We also need to flag UX down to verify the logic/strings make sense here...


(Below for UX)

The new logic here is to display an error saying: "Please enter either title or location." if an event is created without a title or location. (Similar to the error about creating an event that ends before it starts).
Attachment #774986 - Flags: review?(rmacdonald)
Attachment #774986 - Flags: review?(jlal)
Attachment #774986 - Flags: review-
Attachment #774986 - Flags: feedback?
Comment on attachment 774986 [details] [diff] [review]
Proposed patch

Oops! I got your pull requests mixed up (though my comments above about tests are the same)

I have some more input on the code so unflagging rob for review on this bug.
Attachment #774986 - Flags: review?(rmacdonald)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: